Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta.filename to on-disk filename on read #1439

Open
schlafly opened this issue Oct 7, 2024 · 1 comment
Open

Update meta.filename to on-disk filename on read #1439

schlafly opened this issue Oct 7, 2024 · 1 comment
Assignees

Comments

@schlafly
Copy link
Collaborator

schlafly commented Oct 7, 2024

meta.filename is used as a default file name in many places in the pipeline. Currently it is possible for meta.filename to fail to match the actual file name on disk when a file is copied and renamed, changing the actual filename but not the value of the meta.filename metadata.

We decided to follow Webb's example and limit how often this causes problems by:

  1. setting meta.filename to the actual filename when we read a file in roman_datamodels
  2. setting meta.filename to the actual filename when we write a file using roman_datamodels.

I believe we already do (2) but do not actually do (1). We should do both of these.

@schlafly
Copy link
Collaborator Author

schlafly commented Oct 7, 2024

@stscijgbot-rstdms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants