Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the repo before storing circleci artifacts #103

Open
eteq opened this issue Jun 4, 2019 · 1 comment
Open

Clean the repo before storing circleci artifacts #103

eteq opened this issue Jun 4, 2019 · 1 comment
Assignees

Comments

@eteq
Copy link
Collaborator

eteq commented Jun 4, 2019

This comes from #97 and some of the related discussion in #99. Specifically, #97 (comment) is relevant here - now that #99 is merged we may want to do what @obviousrebel suggests there of cleaning before storing the artifacts.

My primary concern with that is mainly #99 (review) - that is, that maybe we want those artifacts to help debug when something goes wrong. But maybe I'm worrying too much? Or we could do this provisionally but if we run into issues later we can roll it back?

cc @laurenmarietta (and @obviousrebel if you have any residual opinion on this)

@astro-josh
Copy link
Contributor

I do see the value of keeping all artifacts, they were helpful in finding an issue found in PR#77 but they do add significant time to the build.

Perhaps creating an environment variable called CLEAN in circleCI that would determine if the repo should be cleaned or not cleaned prior to storing artifacts? That way, if the need arises to debug or view artifacts this environment variable could easily be switched to not clean and store all artifacts to help view useful logs and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants