Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform routine comparison between keyword dictionary and datamodel schemas. #8785

Open
stscijgbot-jp opened this issue Sep 13, 2024 · 9 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3711 was created on JIRA by Tyler Pauly:

Routine comparison between keyword dictionary and datamodels schema is important to keep metadata in sync - last performed in JP-3332.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

Here is the add table: keywords in the keyword dictionary but not in a datamodel
 
||operation||keyword||details||fix||permanently omit||
|add|meta.exposure.measurement_time| [s] Measurement Time model schema not found keyword db found as tmeasure| | |
|add|meta.ref_file.emicorr| model schema not found keyword db is a group| | |
|add|meta.ref_file.emicorr.name| MIRI EMI correction reference file name model schema not found keyword db found as r_miremi| | |
|add|meta.ref_file.mrsptcorr| model schema not found keyword db is a group| | |
|add|meta.ref_file.mrsptcorr.name| MRS point source correction reference file name model schema not found keyword db found as r_mrspt| | |
|add|meta.ref_file.nrm| model schema not found keyword db is a group| | |
|add|meta.ref_file.nrm.name| NRM reference file name model schema not found keyword db found as r_nrm| | |
|add|meta.cal_step.nsclean| NIRSpec 1/f Noise Correction model schema not found keyword db found as s_nsclen| | |
|add|meta.cal_step.spectral_leak| MIRI MRS spectral_leak model schema not found keyword db found as s_spleak| | |
|add|meta.msa_metadata| MSA configuration parameters model schema not found keyword db is a group| | |
|add|meta.msa_metadata.ppsdbver| PPS database version model schema not found keyword db found as ppsdbver| | |
|add|meta.msa_metadata.msacfg10| Unique ID of all the MSA configs within a visit model schema not found keyword db found as msacfg10| | |
|add|meta.msa_metadata.msacfg36| Unique ID of all MSA configs in visit (base 36) model schema not found keyword db found as msacfg36| | |
|add|meta.msa_metadata| MSA configuration parameters model schema not found keyword db is a group| | |
|add|meta.msa_metadata.ppsdbver| PPS database version model schema not found keyword db found as ppsdbver| | |
|add|meta.msa_metadata.msacfg10| Unique ID of all the MSA configs within a visit model schema not found keyword db found as msacfg10| | |
|add|meta.msa_metadata.msacfg36| Unique ID of all MSA configs in visit (base 36) model schema not found keyword db found as msacfg36| | |
|add|meta.msa_metadata| MSA configuration parameters model schema not found keyword db is a group| | |
|add|meta.msa_metadata.ppsdbver| PPS database version model schema not found keyword db found as ppsdbver| | |
|add|meta.msa_metadata.msacfg10| Unique ID of all the MSA configs within a visit model schema not found keyword db found as msacfg10| | |
|add|meta.msa_metadata.msacfg36| Unique ID of all MSA configs in visit (base 36) model schema not found keyword db found as msacfg36| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami| NIRISS AMI information model schema not found keyword db is a group| | |
|add|meta.ami.content| Identifier for oifits content model schema not found keyword db found as content| | |
|add|meta.ami.observer| Who acquired the data model schema not found keyword db found as observer| | |
|add|meta.ami.object| Object identifier model schema not found keyword db found as object| | |
|add|meta.ami.insmode| Instrument mode model schema not found keyword db found as insmode| | |
|add|meta.ami.arrname| Array Name model schema not found keyword db found as arrname| | |
|add|meta.ami.pa| Observation position angle model schema not found keyword db found as pa| | |
|add|meta.ami.calib| Calibration object identifier model schema not found keyword db found as calib| | |
|add|meta.ami.oi_revn_array| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrayx| [m] Array center x model schema not found keyword db found as arrayx| | |
|add|meta.ami.arrayy| [m] Array center y model schema not found keyword db found as arrayy| | |
|add|meta.ami.arrayz| [m] Array center z model schema not found keyword db found as arrayz| | |
|add|meta.ami.frame| Coordinate Frame model schema not found keyword db found as frame| | |
|add|meta.ami.oi_revn_target| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.oi_revn_t3| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_t3| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_t3| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_vis2| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.arrname_vis2| Array name model schema not found keyword db found as arrname| | |
|add|meta.ami.insname_vis2| Name of detector model schema not found keyword db found as insname| | |
|add|meta.ami.oi_revn_wavelength| Revision number of the table definition model schema not found keyword db found as oi_revn| | |
|add|meta.ami.insname_wavelength| Name of detector model schema not found keyword db found as insname| | |

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Sep 13, 2024

Comment by Melanie Clarke on JIRA:

Here is the delete table: keywords that should be added to the keyword dictionary or else added to the ignore list.

 
||operation||keyword||details||fix||permanently omit||
|Update KWD|meta.kernel_xsize|model schema found as kernxsz keyword db not found|Repeat from JP-3332, not needed in KWD. Should omit?| |
|Update KWD|meta.kernel_ysize|model schema found as kernysz keyword db not found|Repeat from JP-3332, not needed in KWD. Should omit?| |
|Update KWD|meta.threshold_percent|model schema found as thrsprc keyword db not found|Repeat from JP-3332, not needed in KWD. Should omit?| |
|Update KWD|meta.dither.dithered_ra|model schema found as dith_ra keyword db not found| | |
|Update KWD|meta.dither.dithered_dec|model schema found as dith_dec keyword db not found| | |
|Update KWD|spec.items.extraction_x|model schema found as extr_x keyword db not found|Repeat from JP-3332. Fix?| |
|Update KWD|spec.items.extraction_y|model schema found as extr_y keyword db not found|Repeat from JP-3332. Fix?| |

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Sep 13, 2024

Comment by Melanie Clarke on JIRA:

Here is the edit table: keywords that exist in both places but the values differ.

 
||operation||keyword||model info||keyword db info||fix||permanently omit||
|edit|meta.instrument.p_band|MRS wavelength band model schema pattern = "^((\ MEDIUM-SHORT|MULTIPLE|LONG-SHORT|SHORT-LONG|ANY|\ SHORT-MEDIUM|N/A|LONG|LONG-MEDIUM|SHORT|MEDIUM-LONG|MEDIUM)\\s*\\|\\s*)+$"
 |keyword db pattern = "^((MEDIUM-SHORT|MULTIPLE|LONG-SHORT|SHORT-LONG|ANY|\ SHORT-MEDIUM|N/A|LONG|LONG-MEDIUM|SHORT|MEDIUM-LONG|MEDIUM)\\s*\\|\\s*)+$"
 |Repeat from JP-3332. No fix needed.| |
|edit|meta.instrument.lamp_state|Name of the lamp used model schema enum = [False, N/A, FLAT2, LINE3, IFU, TEST, REF, IMG, FLAT4, LINE2, LINE4, LINE1, BOTH, G2LAMP1, FLAT1, FLAT3, FLAT5, G1LAMP1, NONE]|keyword db enum = [OFF, FLAT2, LINE3, IFU, TEST, REF, IMG, FLAT4, LINE2, LINE4, LINE1, BOTH, G2LAMP1, FLAT1, FLAT3, FLAT5, G1LAMP1, NONE]|Similar to JP-3332, only OFF/False/N/A are different. No fix needed.| |
|edit|meta.visit.engdb_pointing_quality|Quality of pointing information from EngDB model schema enum = [CALCULATED_FULL, CALCULATED_FULLVA, CALCULATED_GSCMD, PLANNED, CALCULATED_TR_202105, CALCULATED_TRACK_TR_202107, CALCULATED_TR_202105_VA, CALCULATED_ORIGINAL, CALCULATED_GSCMD_V3PAGS, CALCULATED_COARSE_TR_202111, CALCULATED_COARSE_TR_202107, CALCULATED_TRACK_TR_202111, CALCULATED]|keyword db enum = [CALCULATED_GSCMD, PLANNED, CALCULATED_TR_202105, CALCULATED_TRACK_TR_202107, CALCULATED_TR_202105_VA, CALCULATED_ORIGINAL, CALCULATED_GSCMD_V3PAGS, CALCULATED_COARSE_TR_202111, CALCULATED_COARSE_TR_202107, CALCULATED_TRACK_TR_202111, CALCULATED]|Repeat from JP-3332.
From JP-2663: Jonathan Eisenhamer reports that these are old values no longer needed in KWD. Will keep in our schemas for backwards compatibility with old test suites. No fix.| |
|edit|meta.instrument.lamp_mode|Lamp operating mode model schema enum = [N/A, ANY, IFU, FIXEDSLIT, IMAGE, GRATING-ONLY, BRIGHTOBJ, MSASPEC, NONE]|keyword db enum = [IFU, FIXEDSLIT, IMAGE, GRATING-ONLY, BRIGHTOBJ, MSASPEC, NONE]|Repeat from JP-3332. No fix needed.| |
|edit|meta.dither.primary_type|Primary dither pattern type model schema enum = [N/A, SUBARRAY-DITHER, ANY, FULL-TIGHT, NIS-NRC-4L, PFLAT_CORONLYOT, 9-POINT-MIRI-F2100W-WITH-NIRCAM, LFLAT_CORON1140, 3-POINT-MIRI-F1280W-WITH-NIRCAM, 2-POINT-MIRI-F1800W-WITH-NIRCAM, 4-POINT, 2-POINT-MIRI-F1500W-WITH-NIRCAM, 3-POINT-MIRI-F2100W-WITH-NIRISS, NIS-NRC-9M, NIS-MIR180-3, 2-POINT-MIRI-F1280W-WITH-NIRCAM, 4-POINT-MIRI-F1280W-WITH-NIRCAM, 4-POINT-MIRI-F1800W-WITH-NIRCAM, NIS-NRC-2M, 2-POINT-NOD, LFLAT_CORONLYOT, 4-POINT-MIRI-F1500W-WITH-NIRCAM, LONG-CROSS-SCAN-NOD2, 7X3-PIXEL-MAP-NOD2, BACKGROUND, NIS-MIR056-3, REULEAUX, PFLAT_CORON1550, 4-POINT-NOD, 2-POINT-MIRI-F2100W-WITH-NIRCAM, CYCLING, SHORT-CROSS-SCAN-NOD1, 4-POINT-MIRI-F1000W-WITH-NIRISS, INTRAMODULE, 2-POINT-MIRI-F2550W-WITH-NIRISS, 1LOS, 1PIXEL-SLITLESS-SCAN-LONG, 9x3-8x4-SCAN-MAPS-SLITLESS, SHORT-CROSS-SCAN-NOD2, 7PIXEL-9x3-MAP-SLITLESS, NIS-NRC-3S, 4-POINT-MIRI-F770W-WITH-NIRCAM, PFLAT_CORON1065, NIS-NRC-3L, 2-POINT, 7PIX-5PIX-SLIT-SCAN, IMAGING, 2-POINT-WITH-NIRCAM-SIZE2, NIS-MIR150-4, NIS-NRC-9S, 9-POINT-MIRI-F1280W-WITH-NIRISS, 3-POINT-MIRI-F1280W-WITH-NIRISS, NIS-MIR210-3, 9-POINT-MIRI-F770W-WITH-NIRCAM, NIS-MIR100-2, 9-POINT-SMALL-GRID, 5-POINT-SMALL-GRID, NIS-MIR100-3, 5PIXEL-8x4-MAP-SLITLESS, NIS-MIR255-2, 3-POINT-MIRI-F2100W-WITH-NIRCAM, 3-POINT-MIRI-F1800W-WITH-NIRISS, 3-POINT-MIRI-F770W-WITH-NIRCAM, 2-POINT-MIRI-F2100W-WITH-NIRISS, 2-POINT-MIRI-F560W-WITH-NIRISS, LFLAT_CORON1550, 4-POINT-MIRI-F1000W-WITH-NIRCAM, FULLBOX, INTRASCA, NIS-MIR077-3, 1PIXEL-SLITLESS-SCAN-SHORT, NIS-MIR128-2, MAPPING, 3-POINT-WITH-NIRCAM-SIZE3, ALONG-SLIT-NOD, INTRAMODULEBOX, 5PIXEL-SLITLESS-SCAN, LFLAT_CORON1065, NIS-MIR255-4, 2-POINT-WITH-NIRCAM-SIZE3, 3-POINT-WITH-NIRCAM-SIZE1, NIS-MIR150-3, NIS-MIR210-2, 5-POINT-NOD, INTRAPIXEL-SLIT-SCAN-NOD1, 2-POINT-WITH-NIRCAM-SIZE1, NIS-NRC-3M, 9-POINT-MIRI-F1500W-WITH-NIRCAM, NIS-MIR128-3, 2-POINT-MIRI-F1280W-WITH-NIRISS, 2PIXEL-SLITLESS-SCAN-SHORT, NIS-MIR180-4, 3-POINT-WITH-NIRCAM-SIZE2, SHORT-CROSS-SCAN-CENTER, NIS-MIR100-4, NIS-NRC-4M, 2-POINT-MIRI-F770W-WITH-NIRCAM, WFSC, 9-POINT-MIRI-F2550W-WITH-NIRISS, PFLAT_CORON1140, 3-POINT-MIRI-F2550W-WITH-NIRCAM, NIS-MIR077-9, 2-POINT-MIRI-F1800W-WITH-NIRISS, 3-POINT-MIRI-F1000W-WITH-NIRISS, AMI, 3-POINT-MIRI-F1000W-WITH-NIRCAM, 4-POINT-MIRI-F2100W-WITH-NIRISS, NIS-MIR056-2, 9-POINT-MIRI-F1000W-WITH-NIRISS, 3-POINT-MIRI-F1800W-WITH-NIRCAM, NIS-MIR180-2, 9-POINT-MIRI-F1800W-WITH-NIRISS, SCAN-CALIBRATION, 3-POINT-MIRI-F2550W-WITH-NIRISS, 4-POINT-MIRI-F2550W-WITH-NIRISS, 4-POINT-MIRI-F2100W-WITH-NIRCAM, 4-POINT-MIRI-F1280W-WITH-NIRISS, 7X3-PIXEL-MAP-CENTER, 3-POINT-MIRI-F1500W-WITH-NIRCAM, 7X3-PIXEL-MAP-NOD1, INTRAPIXEL-SLIT-SCAN-CENTER, FULL, NIS-MIR150-2, NIS-MIR210-9, 9-POINT-MIRI-F1280W-WITH-NIRCAM, 7x3-PIXEL-MAP-SLITLESS, NONE, NIS-MIR128-9, LONG-CROSS-SCAN-CENTER, SUBARRAY_DITHER, 3-POINT-MIRI-F770W-WITH-NIRISS, NIS-MIR180-9, NIS-MIR150-9, MIMF, 4-POINT-DITHER, 4-POINT-MIRI-F2550W-WITH-NIRCAM, WFSS, NIS-MIR128-4, 2PIXEL-SLIT-SCAN, 2-POINT-MIRI-F2550W-WITH-NIRCAM, 4-POINT-MIRI-F1800W-WITH-NIRISS, NIS-NRC-2L, 3-POINT-NOD, 1PIXEL-SLIT-SCAN, 9-POINT-MIRI-F2550W-WITH-NIRCAM, INTRAPIXEL-SLIT-SCAN-NOD2, 4-POINT-MIRI-F770W-WITH-NIRISS, INTRAMODULEX, 4-POINT-SETS, 9-POINT-MIRI-F770W-WITH-NIRISS, NIS-NRC-9L, NIS-MIR210-4, 7PIXEL-SLITLESS-SCAN, 7PIXEL-SLIT-SCAN, NIS-NRC-4S, NIS-MIR255-3, NIS-MIR255-9, LONG-CROSS-SCAN-NOD1, SPARSE-CYCLING]|keyword db enum = [NIS-NRC-4L, PFLAT_CORONLYOT, 9-POINT-MIRI-F2100W-WITH-NIRCAM, LFLAT_CORON1140, 3-POINT-MIRI-F1280W-WITH-NIRCAM, 2-POINT-MIRI-F1800W-WITH-NIRCAM, 4-POINT, 2-POINT-MIRI-F1500W-WITH-NIRCAM, 3-POINT-MIRI-F2100W-WITH-NIRISS, NIS-NRC-9M, NIS-MIR180-3, 2-POINT-MIRI-F1280W-WITH-NIRCAM, 4-POINT-MIRI-F1280W-WITH-NIRCAM, 4-POINT-MIRI-F1800W-WITH-NIRCAM, NIS-NRC-2M, 2-POINT-NOD, LFLAT_CORONLYOT, 4-POINT-MIRI-F1500W-WITH-NIRCAM, LONG-CROSS-SCAN-NOD2, 7X3-PIXEL-MAP-NOD2, BACKGROUND, NIS-MIR056-3, REULEAUX, PFLAT_CORON1550, 4-POINT-NOD, 2-POINT-MIRI-F2100W-WITH-NIRCAM, CYCLING, SHORT-CROSS-SCAN-NOD1, 4-POINT-MIRI-F1000W-WITH-NIRISS, INTRAMODULE, 2-POINT-MIRI-F2550W-WITH-NIRISS, 1LOS, 1PIXEL-SLITLESS-SCAN-LONG, 9x3-8x4-SCAN-MAPS-SLITLESS, SHORT-CROSS-SCAN-NOD2, 7PIXEL-9x3-MAP-SLITLESS, NIS-NRC-3S, 4-POINT-MIRI-F770W-WITH-NIRCAM, PFLAT_CORON1065, NIS-NRC-3L, 2-POINT, 7PIX-5PIX-SLIT-SCAN, IMAGING, 2-POINT-WITH-NIRCAM-SIZE2, NIS-MIR150-4, NIS-NRC-9S, 9-POINT-MIRI-F1280W-WITH-NIRISS, 3-POINT-MIRI-F1280W-WITH-NIRISS, NIS-MIR210-3, 9-POINT-MIRI-F770W-WITH-NIRCAM, NIS-MIR100-2, 9-POINT-SMALL-GRID, 5-POINT-SMALL-GRID, NIS-MIR100-3, 5PIXEL-8x4-MAP-SLITLESS, NIS-MIR255-2, 3-POINT-MIRI-F2100W-WITH-NIRCAM, 3-POINT-MIRI-F1800W-WITH-NIRISS, 3-POINT-MIRI-F770W-WITH-NIRCAM, 2-POINT-MIRI-F2100W-WITH-NIRISS, 2-POINT-MIRI-F560W-WITH-NIRISS, LFLAT_CORON1550, 4-POINT-MIRI-F1000W-WITH-NIRCAM, FULLBOX, INTRASCA, NIS-MIR077-3, 1PIXEL-SLITLESS-SCAN-SHORT, NIS-MIR128-2, MAPPING, 3-POINT-WITH-NIRCAM-SIZE3, ALONG-SLIT-NOD, INTRAMODULEBOX, 5PIXEL-SLITLESS-SCAN, LFLAT_CORON1065, NIS-MIR255-4, 2-POINT-WITH-NIRCAM-SIZE3, 3-POINT-WITH-NIRCAM-SIZE1, NIS-MIR150-3, NIS-MIR210-2, 5-POINT-NOD, INTRAPIXEL-SLIT-SCAN-NOD1, 2-POINT-WITH-NIRCAM-SIZE1, NIS-NRC-3M, 9-POINT-MIRI-F1500W-WITH-NIRCAM, NIS-MIR128-3, 2-POINT-MIRI-F1280W-WITH-NIRISS, 2PIXEL-SLITLESS-SCAN-SHORT, NIS-MIR180-4, 3-POINT-WITH-NIRCAM-SIZE2, SHORT-CROSS-SCAN-CENTER, NIS-MIR100-4, NIS-NRC-4M, 2-POINT-MIRI-F770W-WITH-NIRCAM, WFSC, 9-POINT-MIRI-F2550W-WITH-NIRISS, PFLAT_CORON1140, 3-POINT-MIRI-F2550W-WITH-NIRCAM, NIS-MIR077-9, 2-POINT-MIRI-F1800W-WITH-NIRISS, 3-POINT-MIRI-F1000W-WITH-NIRISS, AMI, 3-POINT-MIRI-F1000W-WITH-NIRCAM, 4-POINT-MIRI-F2100W-WITH-NIRISS, NIS-MIR056-2, 9-POINT-MIRI-F1000W-WITH-NIRISS, 3-POINT-MIRI-F1800W-WITH-NIRCAM, NIS-MIR180-2, 9-POINT-MIRI-F1800W-WITH-NIRISS, SCAN-CALIBRATION, 3-POINT-MIRI-F2550W-WITH-NIRISS, 4-POINT-MIRI-F2550W-WITH-NIRISS, 4-POINT-MIRI-F2100W-WITH-NIRCAM, 4-POINT-MIRI-F1280W-WITH-NIRISS, 7X3-PIXEL-MAP-CENTER, 3-POINT-MIRI-F1500W-WITH-NIRCAM, 7X3-PIXEL-MAP-NOD1, INTRAPIXEL-SLIT-SCAN-CENTER, FULL, NIS-MIR150-2, NIS-MIR210-9, 9-POINT-MIRI-F1280W-WITH-NIRCAM, 7x3-PIXEL-MAP-SLITLESS, NONE, NIS-MIR128-9, LONG-CROSS-SCAN-CENTER, SUBARRAY_DITHER, 3-POINT-MIRI-F770W-WITH-NIRISS, NIS-MIR180-9, NIS-MIR150-9, MIMF, 4-POINT-DITHER, 4-POINT-MIRI-F2550W-WITH-NIRCAM, WFSS, NIS-MIR128-4, 2PIXEL-SLIT-SCAN, 2-POINT-MIRI-F2550W-WITH-NIRCAM, 4-POINT-MIRI-F1800W-WITH-NIRISS, NIS-NRC-2L, 3-POINT-NOD, 1PIXEL-SLIT-SCAN, 9-POINT-MIRI-F2550W-WITH-NIRCAM, INTRAPIXEL-SLIT-SCAN-NOD2, 4-POINT-MIRI-F770W-WITH-NIRISS, INTRAMODULEX, 4-POINT-SETS, 9-POINT-MIRI-F770W-WITH-NIRISS, NIS-NRC-9L, NIS-MIR210-4, 7PIXEL-SLITLESS-SCAN, 7PIXEL-SLIT-SCAN, NIS-NRC-4S, NIS-MIR255-3, NIS-MIR255-9, LONG-CROSS-SCAN-NOD1, SPARSE-CYCLING]|Repeat from JP-3332.
 
Model contains FULL-TIGHT, SUBARRAY-DITHER, while kwdict does not, could be obsolete values that are intentionally kept in datamodels schema to allow loading old products.| |
|edit|meta.dither.nod_type|Nod pattern type model schema enum = [3-SHUTTER-SLITLET, 3-POINT-NOD, 2-SHUTTER-SLITLET, 5-SHUTTER-SLITLET, NONE, 5-SHUTTER-SLITLET-WITH-GAP]|keyword db enum = [5-SHUTTER-SLITLET-WITH-GAPS, 3-SHUTTER-SLITLET, 3-POINT-NOD, 2-SHUTTER-SLITLET, 5-SHUTTER-SLITLET, NONE, 5-SHUTTER-SLITLET-WITH-GAP]|Keyword db has 5-SHUTTER-SLITLET-WITH-GAPS, model schema does not. | |
|edit|meta.dither.primary_channel|MRS primary channel model schema enum = [ALL, CHANNEL1, CHANNEL2, CHANNEL4, CHANNEL3]|keyword db enum = [IMAGER, ALL_MRS, CHANNEL1, CHANNEL2, CHANNEL4, CHANNEL3]|Keyword db has IMAGER and ALL_MRS, model schema does not. Model schema has ALL.| |
|edit|meta.resample.weight_type|Type of drizzle weighting to use in resampling input model schema enum = [exptime, ivm]|keyword db enum = [IVM, EXPTIME]|Repeat from JP-3332. No real differences.| |
|edit|meta.instrument.lamp_mode|Name of the lamp mode used model schema enum = [N/A, ANY, IFU, FIXEDSLIT, IMAGE, GRATING-ONLY, BRIGHTOBJ, MSASPEC, NONE]|keyword db enum = [IFU, FIXEDSLIT, IMAGE, GRATING-ONLY, BRIGHTOBJ, MSASPEC, NONE]|Repeat from JP-3332. No real differences.| |

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Sep 13, 2024

Comment by Melanie Clarke on JIRA:

Here is the rename table: keywords that exist in both places but have different names

 
||operation||keyword||details||fix||permanently omit||
|rename|meta.dither.primary_points|model schema name = primary_points keyword db name = nod_points|See JWSTKD-555 for details? | |

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Oct 8, 2024

Comment by Linda Thompson on JIRA:

I don't know if this helps or not, and if it doesn't feel free to delete the comment, or let me know and I will.
We have FITS keyword PRIDTPTS defined for each instrument:
fgs.dither.schema.json: "primary_points" : fits_keyword=PRIDTPTS, "Number of points in primary dither pattern"
miri.imaging.dither.schema.json: "primary_points" : fits_keyword=PRIDTPTS, "Number of points in primary dither pattern"
nircam.dither.schema.json: "primary_points" : fits_keyword=PRIDTPTS, "Number of points in primary dither pattern"
niriss.dither.schema.json: "primary_points" : fits_keyword=PRIDTPTS, "Number of points in primary dither pattern"
nirspec.fss.dither.schema.json: "primary_points" : fits_keyword=PRIDTPTS, "Number of points in primary dither pattern"
nirspec.msa.dither.schema.json: "nod_points" : fits_keyword=PRIDTPTS, "Number of points in nod pattern"

So, the Nirspec "data model" name is different because the definition in that specific case is a little different. We could take a JWSTKD ticket to rename "nod_points" to "primary_points" for consistency if that would help.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Brett Graham on JIRA:

https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/123 should address some of the AMI/OIFITS differences. I am quite unfamiliar with grit. Linda Thompson when possible would you give it a look to see if I set up the merge request correctly. Would you be the person to request for review? Thanks!

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Brett Graham on JIRA:

I attached a report of the differences between the keyword dictionary and datamodel schemas generated with the schema_editor replacement. The report was run against the branch of the keyword dictionary in this PR: https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/123

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Brett Graham on JIRA:

https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/124

and

spacetelescope/stdatamodels#354

begin to address some keyword differences. Is there a maintainer of the jwstkd repository that would review the above PR?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Tyler Pauly on JIRA:

After finding some differences, this quickly expanded into more than a comparison - Brett Graham updated the comparison tool itself under https://jira.stsci.edu/browse/JP-3783, and subsequent differences found with the new tool are being addressed through a variety of PRs to stdatamodels and to the keyword dictionary (tracked in part through https://jira.stsci.edu/browse/JWSTKD-582 ). Comparison has been completed for purposes of this ticket - future comparisons and maintenance of the synchrony between the two repositories to be discussed at the next JWSTKD meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant