-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform routine comparison between keyword dictionary and datamodel schemas. #8785
Comments
Comment by Melanie Clarke on JIRA: Here is the add table: keywords in the keyword dictionary but not in a datamodel |
Comment by Melanie Clarke on JIRA: Here is the delete table: keywords that should be added to the keyword dictionary or else added to the ignore list. |
Comment by Melanie Clarke on JIRA: Here is the edit table: keywords that exist in both places but the values differ. |
Comment by Melanie Clarke on JIRA: Here is the rename table: keywords that exist in both places but have different names |
Comment by Linda Thompson on JIRA: I don't know if this helps or not, and if it doesn't feel free to delete the comment, or let me know and I will. So, the Nirspec "data model" name is different because the definition in that specific case is a little different. We could take a JWSTKD ticket to rename "nod_points" to "primary_points" for consistency if that would help. |
Comment by Brett Graham on JIRA: https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/123 should address some of the AMI/OIFITS differences. I am quite unfamiliar with grit. Linda Thompson when possible would you give it a look to see if I set up the merge request correctly. Would you be the person to request for review? Thanks! |
Comment by Brett Graham on JIRA: I attached a report of the differences between the keyword dictionary and datamodel schemas generated with the schema_editor replacement. The report was run against the branch of the keyword dictionary in this PR: https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/123 |
Comment by Brett Graham on JIRA: https://grit.stsci.edu/OED_DSB/jwstkd/-/merge_requests/124 and spacetelescope/stdatamodels#354 begin to address some keyword differences. Is there a maintainer of the jwstkd repository that would review the above PR? |
Comment by Tyler Pauly on JIRA: After finding some differences, this quickly expanded into more than a comparison - Brett Graham updated the comparison tool itself under https://jira.stsci.edu/browse/JP-3783, and subsequent differences found with the new tool are being addressed through a variety of PRs to stdatamodels and to the keyword dictionary (tracked in part through https://jira.stsci.edu/browse/JWSTKD-582 ). Comparison has been completed for purposes of this ticket - future comparisons and maintenance of the synchrony between the two repositories to be discussed at the next JWSTKD meeting. |
Issue JP-3711 was created on JIRA by Tyler Pauly:
Routine comparison between keyword dictionary and datamodels schema is important to keep metadata in sync - last performed in JP-3332.
The text was updated successfully, but these errors were encountered: