Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1401: Updating main branch based on changes on 3.9.0 (build-related changes) #1922

Merged

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Dec 17, 2024

Resolves HLA-1401

Closes #1921

This PR cleans up the main branch. We have been making build-related changes on branch 3.9.0, however, there are some changes that are only on main that we don't want to clobber with a merge. I have therefore added difference manually in one go in order to avoid conflicts.

These changes include changes to the pyproject.toml and requirements-dev.txt file that specify the requirement for numpy > 2.0. I have also updated the changelog, skipped two SVM tests (similar to build), and added an ADR about our dependency pinning strategy.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

Jenkins Test

@s-goldman s-goldman added the code cleanup Code refactoring, cleanup of temporary code label Dec 17, 2024
@s-goldman s-goldman requested review from mdlpstsci and a team as code owners December 17, 2024 15:38
Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the synchronization to 3.9.0x!

@s-goldman s-goldman merged commit 21f7188 into spacetelescope:main Dec 17, 2024
15 of 17 checks passed
@s-goldman s-goldman deleted the hla-1401_update_main_branch_12_17_24 branch December 17, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code refactoring, cleanup of temporary code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Drizzlepac main branch
2 participants