Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlated noise between STIPS runs #118

Open
benw1 opened this issue Nov 20, 2020 · 6 comments
Open

Correlated noise between STIPS runs #118

benw1 opened this issue Nov 20, 2020 · 6 comments

Comments

@benw1
Copy link
Collaborator

benw1 commented Nov 20, 2020

I am finding that the noise in different STIPS-produced images is correlated. That is, if I run two different bands with 2 different SEED values, the noise peaks in each will be in the same pixels. This caused much trouble for source detection algorithms using the combined significance of counts across different bands.

@benw1
Copy link
Collaborator Author

benw1 commented Nov 20, 2020

This may be a reappearance of issue #21 ... not sure, except it is not using the cpu_pool

@benw1
Copy link
Collaborator Author

benw1 commented Nov 20, 2020

Updated STIPS, and am now retesting...

@york-stsci
Copy link
Collaborator

Any results from retesting?

@benw1
Copy link
Collaborator Author

benw1 commented Oct 26, 2021

This correlated noise is still occurring with the latest dev16 version. I'm setting the seed in the ObservationModule() using "random_seed" but the noise is correlated between runs. The background noise doesn't show this. I can see it best if I don't include a background, so it is likely something to do with how the read noise is being added.

@york-stsci
Copy link
Collaborator

To confirm, what you are doing is creating two ObservationModule() objects, each with a different input value of random_seed, but getting the same noise values?

@benw1
Copy link
Collaborator Author

benw1 commented Oct 26, 2021

I may have set the seed in the wrong line of the code. Please ignore for the moment while I continue testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants