Add -threads and -nonces arguments to be used with -genproof #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Sep 1, 2023
| @@ -74,6 +77,9 @@ func parseFlags() { | |||
| flag.StringVar(&commitmentAtxIdHex, "commitmentAtxId", "", "commitment atx id, in hex (required)") | |||
| numUnits := flag.Uint64("numUnits", uint64(opts.NumUnits), "number of units") | |||
|
|
|||
| flag.UintVar(&nonces, "nonces", 16, "number of nonces for -genproof") | |||
There was a problem hiding this comment.
The number of nonces must be a multiple of 16 (a nonce group). How about changing this argument into "number of nonce groups" to avoid setting an invalid value? Also, 16 is unrealistic, perhaps a more typical value like 288 would be better?
Suggested change
| flag.UintVar(&nonces, "nonces", 16, "number of nonces for -genproof") | |
| flag.UintVar(&noncesGroups, "nonceGroups", 18, "number of nonce groups for -genproof. Each group consists of 16 nonces.") |
And multiply it by 16 later in the code.
OR at least inform the user that it must be a multiple of 16:
Suggested change
| flag.UintVar(&nonces, "nonces", 16, "number of nonces for -genproof") | |
| flag.UintVar(&nonces, "nonces", 16, "number of nonces for -genproof. Must be a multiple of 16.") |
Comment on lines
+38
to
+39
| log.Printf("Generating proof with: %d nonces and %d threads.\n", options.nonces, options.threads) | ||
| logger.Info("proving: start generating proof") |
There was a problem hiding this comment.
Nonces and threads can be added directly into the second log.
Suggested change
| log.Printf("Generating proof with: %d nonces and %d threads.\n", options.nonces, options.threads) | |
| logger.Info("proving: start generating proof") | |
| logger.Info("proving: start generating proof", zap.Uint("nonces", options.nonces), zap.Uint("threads", options.threads)) |
|
Closing due to inactivity, feel free to re-open if you think this is still useful 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221