Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - sql: add Database.WithConnection #6445

Closed
wants to merge 4 commits into from

sql: add Database.Connection/WithConnection, interface cleanup

ca2d5c6
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - sql: add Database.WithConnection #6445

sql: add Database.Connection/WithConnection, interface cleanup
ca2d5c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 1s

79.9% (-0.1%) compared to f711c61

View this Pull Request on Codecov

79.9% (-0.1%) compared to f711c61

Details

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (f711c61) to head (ca2d5c6).

Files with missing lines Patch % Lines
sql/database.go 43.7% 13 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6445     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.1%     
=========================================
  Files          352     352             
  Lines        46096   46121     +25     
=========================================
- Hits         36865   36856      -9     
- Misses        7142    7167     +25     
- Partials      2089    2098      +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov