Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples are missing required MsTeamsChannel in Deployment templates #308

Open
MartinLuccanera opened this issue Aug 27, 2021 · 0 comments
Open
Labels

Comments

@MartinLuccanera
Copy link

MartinLuccanera commented Aug 27, 2021

Context

For more information, see the parent issue. {{Link to parent issue for more information}}

Sample information

  1. Sample type: Samples
  2. Sample language: Deployment templates
  3. Sample name: Several

Describe the bug

While testing these bots, we found out that they required an MsTeamsChannel and deployment templates were NOT creating them.

Here's a list of all the cases we found

Bots Affected ARM Templates
samples/csharp_dotnetcore/46.teams-auth • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/46.teams-auth • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/50.teams-messaging-extensions-search • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/51.teams-messaging-extensions-action • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/52.teams-messaging-extensions-search-auth-config • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/53.teams-messaging-extensions-action-preview • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/54.teams-task-module • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/55.teams-link-unfurling • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/56.teams-file-upload • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/57.teams-conversation-bot • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/java_springboot/58.teams-start-new-thread-in-channel • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/javascript_nodejs/46.teams-auth • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/typescript_nodejs/50.teams-messaging-extensions-search • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/typescript_nodejs/51.teams-messaging-extensions-action • template-with-new-rg.json
• template-with-preexisting-rg.json
samples/typescript_nodejs/58.teams-start-new-thread-in-channel • template-with-new-rg.json
• template-with-preexisting-rg.json
experimental/composer-samples/csharp_dotnetcore/projects/51.teams-messaging-extensions-action/teamsmessagingextensionsaction • template-with-new-rg.json
• template-with-preexisting-rg.json
experimental/composer-samples/csharp_dotnetcore/projects/57.teams-conversation-bot/teams-conversation-bot • template-with-new-rg.json
• template-with-preexisting-rg.json
experimental/teams-sso/csharp_dotnetcore • template-with-new-rg.json
• template-with-preexisting-rg.json

Expected behavior

Bots work out the box using the provided deployment templates.

Actual behavior

Manual creation of MsTeamsChannel was required to make bots work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant