Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update dependencies of Microsoft.Rest.ClientRuntime.Azure.TestFramework & Microsoft.Rest.ClientRuntime.Azure.Authentication #175

Open
gasper-az opened this issue Feb 20, 2019 · 0 comments

Comments

@gasper-az
Copy link

gasper-az commented Feb 20, 2019

NOTE: this ISSUE will be created in Azure-sdk-for-net repository

Is your feature request related to a problem? Please describe.
When trying to update the Microsoft.Rest.ClientRuntime.Azure.TestFramework to the latest version (1.7.6), which will be used along the Microsoft.Bot.Connector 4.1.5, we are having the next dependencies errors:

Project Microsoft.Rest.ClientRuntime.Azure.TestFramework 1.7.6 Microsoft.Bot.Connector 4.1.5
Version of Microsoft.IdentityModel.Clients.ActiveDirectory required >= 3.14.0 && < 4.0.0 >= 4.5.0
Version of Microsoft.IdentityModel.Tokens required = 5.1.2 >= 5.2.1

Also, we noticed that the Microsoft.Rest.ClientRuntime.Azure.Authentication v2.3.7 requires the usage of Microsoft.IdentityModel.Clients.ActiveDirectory greater or equal than v3.14.0 and minor to 4.0.0.

Describe the solution you'd like
It's necessary to update the next required versions:

  • Microsoft.IdentityModel.Clients.ActiveDirectory to 4.5.1, because the latest version allowed by both Microsoft.Rest.ClientRuntime.Azure.TestFramework and Microsoft.Rest.ClientRuntime.Azure.Authentication is the 3.19.8 (should be minor to 4.0.0), which was released 8 months ago (link)

  • Microsoft.IdentityModel.Tokens to 5.4.0, because the latest version allowed by Microsoft.Rest.ClientRuntime.Azure.TestFramework should be 5.2.1, which was released 6 months ago (link)

Steps to reproduce
As we are currently working on the BotBuilder-Dotnet repository, the steps to reproduce the ISSUE mentioned above are:

  • Clone the BotBuilder-Dotnet repository
  • Open the Microsoft.Bot.Builder.sln solution in Visual Studio 2017
  • Build Microsoft.Bot.Connector.Tests project under the Tests folder
  • You will see the next Warning:
    warning NU1608: Detected package version outside of dependency constraint: Microsoft.Azure.Test.HttpRecorder 1.7.0 requires Newtonsoft.Json (>= 9.0.1 && < 10.0.0) but version Newtonsoft.Json 10.0.3 was resolved.

This is because we are using Microsoft.Rest.ClientRuntime.Azure.TestFramework v1.6.0, which one of its dependencies is Microsoft.Azure.Test.HttpRecorder 1.7.0, which also has the next constraint on the Newtonsoft.Json package:

image

Here is a screenshot of the .csproj file:
image

Also, is important to highlight that we have a reference to another project of this solution, which is Microsoft.Bot.Connector v4.1.5 :

image

image

  • Trying to solve the previous ISSUE, update the Microsoft.Rest.ClientRuntime.Azure.TestFramework to its latest version v1.7.6
  • After trying updating this dependency, the next error (which correspond to the first dependency issue we mentioned above) will be shown:

image

Note
These are the current NuGet packages we are using on Microsoft.Bot.Connector.Test project:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant