Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message should be WARN or INFO message when the data bag item "dnsmasq" "managed_hosts" isn't found #70

Open
haidangwa opened this issue Dec 29, 2020 · 1 comment

Comments

@haidangwa
Copy link

haidangwa commented Dec 29, 2020

👻 Brief Description

Chef logs an ERROR when the data bag item dnsmasq managed_hosts is not found. This data bag item is optional, so it shouldn't be logged as an ERROR. Perhaps a WARN is more appropriate or no message at all.

[2020-12-29T08:50:42+00:00] ERROR: Failed to load data bag item: "dnsmasq" "managed_hosts"

🥞 Cookbook version

0.3.4

👩‍🍳 Chef-Infra Version

Chef 15 & 16

🎩 Platform details

RHEL8

Steps To Reproduce

Steps to reproduce the behavior:

  1. Run the dnsmasq::dns recipe with all attributes unmodified from their default values
  2. look at the Chef Infra Client log file output

🚓 Expected behavior

The message logged should not be ERROR level since the data bag item is optional.

➕ Additional context

Add any other context about the problem here. e.g. related issues or existing pull requests.

@ramereth
Copy link
Contributor

@haidangwa please feel free to create PR which addresses this. We'll review and get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants