Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add 'Install the browser extension' alert, remove the popup #14196

Closed
AlicjaSuska opened this issue Sep 25, 2020 · 3 comments · Fixed by #14399
Closed

Add 'Install the browser extension' alert, remove the popup #14196

AlicjaSuska opened this issue Sep 25, 2020 · 3 comments · Fixed by #14399
Assignees
Labels
estimate/3d RFC-221 Browser extension - improve discoverability and awerness webapp

Comments

@AlicjaSuska
Copy link
Contributor

AlicjaSuska commented Sep 25, 2020

Part of RFC 221: Improve discoverability/awareness of the browser extension

Description

  • remove the 'install browser extension popup'
  • add info alert to the file view pages

Design documentation

  1. The alert:
    View in Figma
  • Use the info alert styles. Limit number of characters to 66 per line.
  • Display the alert for the first time after the user saw at least 2 hovers (code intel tooltips)
  • Display only on the file view, until user dismissed it (x button). Don't show again.
  • Use the code host logo and name in the popup. The code host name will be taken from the currently viewed file (ex. for the file from GitHub, we will show the GitHub logo and copy)
  • Add subtle flashing background animation behind the code host logo to draw more attention to the alert. See the video showing the animation or open the prototype. Animation specs: ease in and out 800ms, delay 800ms.
  1. Alert variants
  • Content of the alert changes depending on the code host of the currently viewed file for Chrome and Firefox users (once the Firefox extension is fixed)
  • For users of other browsers, content of the alert changes as well
    See all the alert content variants
  1. Dismissing the alert + tooltip
  • When the user dismisses the alert, inform about the link in the user dropdown menu by showing a contextual tooltip
    View in Figma
  • See the video showcasing the animation or go to the prototype
  • Animation specs: click on the X button -> 100ms delay -> tooltip eases out (400ms) -> delay 50ms -> background behind the profile icon eases out (800ms) -> delay 3s -> both tooltip and background ease out (800ms)

As per @felixfbecker comment this point was moved to the separate issue
3. Display different alert content if the admin turned on Sourcegraph on the code host level

  • ‘Sourcegraph's code intelligence will follow you to your code host. Your site admin set up the Sourcegraph native integration for [code host]. Learn more or just try it out’
  • possible for GitLab, Bitbucket Server, and Phabricator

Stats

@AlicjaSuska
Copy link
Contributor Author

As @felixfbecker suggested, I moved point 3 to issue #14267 @tjkandala

@AlicjaSuska
Copy link
Contributor Author

@tjkandala please, see the updated copy for alerts:

  • 'MRs' instead of 'PRs' for GitLab
  • 'while browsing and reviewing code' for Phabricator

@tjkandala tjkandala linked a pull request Oct 8, 2020 that will close this issue
5 tasks
@tjkandala
Copy link
Contributor

Closed by #14256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
estimate/3d RFC-221 Browser extension - improve discoverability and awerness webapp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants