Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gl to v8 #1630

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Upgrade gl to v8 #1630

wants to merge 19 commits into from

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Apr 1, 2024

Description

Refer to their release notes.

Now, we have prebuilt binaries shipped for most systems, so it will save us so much time (and compute resources – especially for GitHub Actions runners) to not have to build from source each time.

Beyond that, they also add GCC 13 support. Closes #1417. Will also close #1508 as unplanned (as the root cause is fixed – no more motivation to necessarily move out).

Also updates to latest Yarn and bumps Prettier

@RichDom2185 RichDom2185 requested a review from sayomaki April 1, 2024 17:20
@RichDom2185 RichDom2185 self-assigned this Apr 1, 2024
@RichDom2185
Copy link
Member Author

@sayomaki we need to figure out how to resolve the require on ESM error&hellip... it's blocking our gl migration for both frontend and js-slang :(

Should we just use Yarn 3?

@RichDom2185 RichDom2185 marked this pull request as draft April 1, 2024 17:24
@RichDom2185
Copy link
Member Author

@sayomaki I think best to just use latest Yarn. Doesn't hurt anyway.

@RichDom2185 RichDom2185 marked this pull request as ready for review August 15, 2024 12:28
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 15, 2024 12:28
@RichDom2185 RichDom2185 disabled auto-merge August 15, 2024 12:31
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 15, 2024 12:35
@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 10403964584

Details

  • 61 of 83 (73.49%) changed or added relevant lines in 13 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 81.499%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/errors.ts 3 5 60.0%
src/errors/typeErrors.ts 25 31 80.65%
src/typeChecker/internalTypeErrors.ts 2 8 25.0%
src/errors/errors.ts 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
src/modules/errors.ts 1 75.0%
src/typeChecker/internalTypeErrors.ts 3 42.11%
src/errors/errors.ts 3 65.15%
Totals Coverage Status
Change from base Build 9988348374: -0.03%
Covered Lines: 10946
Relevant Lines: 13065

💛 - Coveralls

@RichDom2185 RichDom2185 disabled auto-merge August 15, 2024 12:43
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 15, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate possible migration out of gpu.js/angle Cannot npm install due to gpu.js/angle not compiling
3 participants