Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ESLint and related dependencies #2986

Merged
merged 11 commits into from
May 5, 2024
Merged

Bump ESLint and related dependencies #2986

merged 11 commits into from
May 5, 2024

Conversation

RichDom2185
Copy link
Member

Description

Closes #2973. Refer to the linked issue for details.

eslint-plugin-react-refresh is a newly installed plugin that will ease our migration to Vite. We install the canary version as the stable version that supports ESLint v9 will only be released alongside React 19.

Also added TODOs to eventually make the code quality stricter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

yarn eslint works.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces May 3, 2024 11:39
@RichDom2185 RichDom2185 self-assigned this May 3, 2024
@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8959901428

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 32.731%

Files with Coverage Reduction New Missed Lines %
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentDeploymentTab.tsx 1 0.0%
src/commons/XMLParser/XMLParserHelper.ts 1 0.0%
Totals Coverage Status
Change from base Build 8959899390: 0.0%
Covered Lines: 5146
Relevant Lines: 14691

💛 - Coveralls

@RichDom2185 RichDom2185 marked this pull request as draft May 3, 2024 11:47
@RichDom2185
Copy link
Member Author

As expected, CRA makes the dev experience a nightmare…

image

It's using an old version of ESLint which makes it incompatible. I think we should disable ESLint in the dev server and let us handle the linting separately.

@RichDom2185 RichDom2185 marked this pull request as ready for review May 3, 2024 14:47
Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we track these pending comments as new issues with the high/ critical tag? I assume these changes will be done during the Vite or React19 migration.

package.json Show resolved Hide resolved
@RichDom2185 RichDom2185 enabled auto-merge (squash) May 5, 2024 17:19
@RichDom2185 RichDom2185 disabled auto-merge May 5, 2024 17:19
@RichDom2185 RichDom2185 enabled auto-merge (squash) May 5, 2024 17:19
@RichDom2185 RichDom2185 merged commit 2b6dbc3 into master May 5, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the bump-deps-eslint branch May 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESLint flat config (and v9)
3 participants