Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching of dependencies for Pull Requests for Cl check #1035

Open
kjw142857 opened this issue Nov 8, 2023 · 0 comments · May be fixed by #1041
Open

Fix caching of dependencies for Pull Requests for Cl check #1035

kjw142857 opened this issue Nov 8, 2023 · 0 comments · May be fixed by #1041
Assignees
@RichDom2185

Comments

@kjw142857
Copy link
Contributor

kjw142857 commented Nov 8, 2023 •
edited
Loading

Currently, if the dependency file is changed in a PR to use legacy dependencies, the Cl check will (correctly) automatically fail due to incompatible dependencies. However, the incompatible dependencies are cached by Github using the cache key, which results in the Cl check still failing even after the dependencies are updated to the correct ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecations, caching, update actions workflow RichDom2185/source-academy-backend
2 participants
@RichDom2185 @kjw142857