Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to authenticate via SoundCloud, sign-in callback is trying to access a cross-origin frame #77

Open
sergibondarenko opened this issue Dec 28, 2016 · 2 comments
Open

Fail to authenticate via SoundCloud, sign-in callback is trying to access a cross-origin frame #77

sergibondarenko opened this issue Dec 28, 2016 · 2 comments

Comments

@sergibondarenko
Copy link

sergibondarenko commented Dec 28, 2016 •
edited
Loading

SoundCloud SDK v3.1.2
I registered my App approximately 1 year ago.

Today I discovered that my SoundCloud (SC) sign-in stopped working.

When I click on the button the SC pop-up appears with message "Allow “domain.com” access to your SoundCloud account?" I click connect and get the callback pop-up with the message "This popup should automatically close in a few seconds". The callback pop-up never closes. And in the dev console (for the callback pop-up) I see the following errors:

Chrome 55.0.2883.87 m (64-bit)

    VM2980 callback.html?code=3717208…&state=SoundCloud_Dialog_508d9:7 Uncaught DOMException: Blocked a frame with origin "http://domain.com" from accessing a cross-origin frame.
        at onload (http://domain.com/callback.html?code=3717208cc602aba6cc0195157ecd2b6b&state…8d9#access_token=1-166020-17988851-e8f6b064d7ccd4&scope=non-expiring:7:105)
    onload @ VM2980 callback.html?code=3717208…&state=SoundCloud_Dialog_508d9:7

Firefox 50.1.0
Error: Permission denied to access property "SC" callback.html:1:1
Learn More

My callback.html:

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>Connect with SoundCloud</title>
  </head>
  <body onload="window.setTimeout(window.opener.SC.connectCallback, 1);">
    <p>
      This popup should automatically close in a few seconds
    </p>
  </body>
</html>

The JavaScript function (in AngularJS 1.6 controller) that is triggered by a button on my page:

... 
      this.connect_sc = function () {
        debugger;
      // initiate auth popup
        SC.connect().then(function () {
          debugger;
          return SC.get('/me');
        }).then(function (me) {
          debugger;
          userPerma = me.permalink;
          setScUi(me.username, me.avatar_url);
          getPlaylists();
        });
      };
...

I tried to debug it putting some breakpoints. Here I don't get SC promise executed, it breaks only on the first debugger; after I click on my button.

Why is that and how to fix it?
@sergibondarenko sergibondarenko mentioned this issue Dec 28, 2016
Open
@sergibondarenko sergibondarenko changed the title SoundCloud sign-in callback accessing a cross-origin frame Fail to authenticate via SoundCloud, sign-in callback accessing a cross-origin frame Dec 28, 2016
@sergibondarenko sergibondarenko changed the title Fail to authenticate via SoundCloud, sign-in callback accessing a cross-origin frame Fail to authenticate via SoundCloud, sign-in callback is trying to access a cross-origin frame Dec 28, 2016
@digitalillusion
Copy link

digitalillusion commented Mar 12, 2017 •
edited
Loading

you need to specify the same document.domain on both frames, and it should match in order to work.
for instance, if you make SC authentication on www.example.com and the connect dialog redirect on oauth.example.com, then document.domain should resolve to example.com for both

Further reading: source

@bradley-varol
Copy link

bradley-varol commented Sep 11, 2018 •
edited
Loading

Can someone please explain to me an actual fix or workaround for this issue?
I have sc auth on the same domain that the callback is on and receive Blocked a frame with origin "[redacted]" from accessing a cross-origin frame.

@MarcelRaschke MarcelRaschke mentioned this issue Aug 20, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 20, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this issue Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@digitalillusion @sergibondarenko @bradley-varol