Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to "noqa" option #3

Open
pricco opened this issue Jul 5, 2017 · 1 comment
Open

Add support to "noqa" option #3

pricco opened this issue Jul 5, 2017 · 1 comment
Assignees

Comments

@pricco
Copy link
Member

pricco commented Jul 5, 2017

I think it would be helpful to support a skip match parameter:

{skip: /noqa/}

@rlopezcc
Copy link
Contributor

rlopezcc commented Aug 2, 2017

Combining the two matches sounds like a headache, because of how the current code is structured, and could be confusing. The same effect could be achieved using lookarounds.

I've been working on this patch, which allows you to add an arbitrary function in order to invalidate a match based on the line string or file-wide contents (this contemplates the case of file-level noqa).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants