safety: fix safeify_url() exception on python 3.11 #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-duplex
added
the
Bugfix
dgw
reviewed
Nov 21, 2024
half-duplex
force-pushed
the
safety-invalid-urls
branch
from
ce4198c to
61b2196
Compare
|
Also removed the depluralizing on "1 of 1 engines" since both dgw and I think always-plural is a little less weird there, but that's up for debate. |
Exirel
requested changes
Nov 21, 2024
half-duplex
force-pushed
the
safety-invalid-urls
branch
from
61b2196 to
8977dbe
Compare
Exirel
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2644, or at least makes it not an uncaught exception.
Checklist
make qa(runsmake lintandmake test)