[swss] Add support for PoE feature #3238
Conversation
|
|
||
| SWSS_LOG_NOTICE("POE: Initialize"); | ||
| if (!poe.isPoeEnabled()) { | ||
| SWSS_LOG_WARN("POE: not enabled"); |
There was a problem hiding this comment.
For non-poe platforms we may not want log a warning message. Maybe we can skip this log if "!platformHasPoe"
There was a problem hiding this comment.
added an additional check, so that if the platform does not not support PoE (doesn't have a poe_config.json file present) then we do not print anything
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
2 times, most recently
from
acc1489
to
17ff200
Compare
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
from
17ff200
to
f3377d8
Compare
| return false; | ||
| } | ||
|
|
||
| bool PoeConfig::loadDeviceConfig(const std::vector<FieldValueTuple> &ovalues) |
There was a problem hiding this comment.
The loadDeviceConfig, loadPseConfig, and loadPortConfig functions always return true, even though some fields might be missing or invalid.
Could you add error handling that logs and returns false?
There was a problem hiding this comment.
added exception handling (for std::stoul()) and error logs
| type = token.at(0); | ||
| idx = token.at(1); | ||
| } | ||
|
|
There was a problem hiding this comment.
if token.size() is not 1 or 2, this is and error that should be logged and handled.
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
from
f3377d8
to
143edcc
Compare
|
@prgeor could you please review these changes? |
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
from
3bbd09b
to
81e81ff
Compare
Add poesyncd daemon Parse PoE-related configs *What I did* Add support for PoE based on sonic-sairedis support of multiple switches. *How I verified it* Builds and tests using VS builds. Signed-off-by: Serhiy Boiko <[email protected]>
Signed-off-by: Serhiy Boiko <[email protected]>
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
from
81e81ff
to
e97143f
Compare
What I did
Add support for PoE based on sonic-sairedis support of multiple switches
This PR depends on sonic-net/sonic-swss-common#894
Why I did it
How I verified it
Builds and tests using VS builds.
Details if related