Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository clean up #822

Closed
VincentLanglet opened this issue Aug 15, 2020 · 17 comments
Closed

Repository clean up #822

VincentLanglet opened this issue Aug 15, 2020 · 17 comments

Comments

@VincentLanglet
Copy link
Member

VincentLanglet commented Aug 15, 2020 •
edited
Loading

When I looked at the sonata repository, I found

CC @sonata-project/contributors
@core23
Copy link
Member

core23 commented Aug 15, 2020 

* A fork: https://github.com/sonata-project/recipes-contrib
  I think we can remove it

👍

* Some pack: https://github.com/sonata-project/notification-orm-pack, https://github.com/sonata-project/media-orm-pack
  I don't like the fact we have two arbitrary existing pack, and they are not used. IMHO we should deprecate/remove them.
* Some empty pack: https://github.com/sonata-project/media-phpcr-pack, https://github.com/sonata-project/classification-orm-pack, https://github.com/sonata-project/classification-odm-pack, https://github.com/sonata-project/news-orm-pack, https://github.com/sonata-project/news-odm-pack
  I think we should remove it

We use them here (https://github.com/symfony/recipes-contrib/tree/master/sonata-project) or did you mean that nobody is using symfony flex with sonata?

* A deprecated one without [deprecated]: [sonata-project/cache#49](https://github.com/sonata-project/cache/issues/49)
  @greg0ire Can you add the [deprecated] prefix in the description like you did for others ?

Maybe we could use probot for metadata updates. There was an issue to add probot, but we did not add any config.

* Three deprecated ones: https://github.com/sonata-project/SonataCoreBundle, https://github.com/sonata-project/SonataEasyExtendsBundle, https://github.com/sonata-project/SonataCacheBundle.
  Should we archived them ?

👍

* A POC: [sonata-project/SonataAdminSearchBundle#160](https://github.com/sonata-project/SonataAdminSearchBundle/issues/160)
  As explained in the issue, we should abandon it.

👍

* PHPCR bundle: https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle
  We recently abandoned the project. It will be soon in the Readme. Should we add `[abandonned]` in the description ?

👍

* A Repository flag as WIP: https://github.com/sonata-project/SonataDashboardBundle
  Not sure what we should do about it...

We should remove the WIP. The bundle is working, also the implementation is not very good. There are some design issues.

@VincentLanglet
Copy link
Member Author 

* Some pack: https://github.com/sonata-project/notification-orm-pack, https://github.com/sonata-project/media-orm-pack
  I don't like the fact we have two arbitrary existing pack, and they are not used. IMHO we should deprecate/remove them.
* Some empty pack: https://github.com/sonata-project/media-phpcr-pack, https://github.com/sonata-project/classification-orm-pack, https://github.com/sonata-project/classification-odm-pack, https://github.com/sonata-project/news-orm-pack, https://github.com/sonata-project/news-odm-pack
  I think we should remove it

We use them here (https://github.com/symfony/recipes-contrib/tree/master/sonata-project) or did you mean that nobody is using symfony flex with sonata?

I was talking about the install stat from packagist, example: https://packagist.org/packages/sonata-project/media-odm-pack/stats

People seems to use composer require sonata-project/media-bundle sonata-project/doctrine-orm-admin-bundle rather than using the pack. And I understand that, how to know there is a pack for this case when there is none for every other case ? Even our documentation is not talking about these.

Based on this, we should IMHO either create pack every possible set of dependencies and promote them or create none.
Since I don't see any advantage for the pack, and this will be a lot of work, my choice goes for NONE.

* A deprecated one without [deprecated]: [sonata-project/cache#49](https://github.com/sonata-project/cache/issues/49)
  @greg0ire Can you add the [deprecated] prefix in the description like you did for others ?

Maybe we could use probot for metadata updates. There was an issue to add probot, but we did not add any config.

Could be great. Less work for admin !

[...]

Repository to archived, Wip removal, [abandonned] prefix, ... can only be done by admin. (It's kinda sad...)

@greg0ire
Copy link
Contributor

Can you add the [deprecated] prefix in the description like you did for others ?

Done

@core23 core23 mentioned this issue Aug 16, 2020
Closed
@OskarStark
Copy link
Member

@rande can you please

@VincentLanglet
Copy link
Member Author

Everything is done, except:

Can we deprecate/remove these ? This does not seems useful.

Can we archive these ?

@jordisala1991
Copy link
Member

I dont think we should deprecate packs. Those repos will be useful when someone wants to work on that. Asking rande to create them took some time.

For the deprecated repos, IMO they should be archived only when they are not used by our repos, I think the cache thing is still used

@core23
Copy link
Member

core23 commented Sep 27, 2020

That's right we must remove the usage of the cache first, e.g. the block bundles uses it.

@VincentLanglet
Copy link
Member Author

I dont think we should deprecate packs. Those repos will be useful when someone wants to work on that.

Fact is that we have only pack for some association, and they don't have a lot of visibility.
Since 90% of possible packs does not exists, people won't think to use pack when it exists. And if you look at packagist, they are indeed almost not used. I would have prefer improving the doc, if needed, but I think the install is already easy.

Asking rande to create them took some time.

Can't @OskarStark or @greg0ire have the right to manage repository ?

For the deprecated repos, IMO they should be archived only when they are not used by our repos, I think the cache thing is still used

Indeed, I'll see how hard is it to stop using it.

@jordisala1991
Copy link
Member

For some time we didnt even mentioned in our docs so that is something that affects the usage. We added the needed docs for the packs like 2-3 months ago

@core23
Copy link
Member

core23 commented Sep 27, 2020

Btw. we should leave a hint here, that the bundles are deprecated.

@VincentLanglet
Copy link
Member Author

Btw. we should leave a hint here, that the bundles are deprecated.

Indeed, same for

Could it be done automatically ?

@OskarStark
Copy link
Member

I think all of them have docs/installation.rst, not checked yet, but this could be a possibility!

@OskarStark
Copy link
Member

Can't @OskarStark or @greg0ire have the right to manage repository ?

I asked @rande via Slack

@VincentLanglet
Copy link
Member Author

Should we mark https://github.com/sonata-project/GoogleAuthenticator as abandoned ? There was no release since 2018

@OskarStark
Copy link
Member

What's is needed for a release?

@VincentLanglet
Copy link
Member Author

What's is needed for a release?

I dont know if there is something to release but

  • There is some issue opened without answer
  • There was no new development for 2 years
    Isnt it the definition of an abandoned package ?

I just see the "abandoned" tag like a way to say "No active development"

@VincentLanglet
Copy link
Member Author

GoogleAuthenticator had a new release, so I think it's not a subject.

IMHO the last things to do is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@greg0ire @OskarStark @jordisala1991 @core23 @VincentLanglet