Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] stock_picking_move_description #150

Open
wants to merge 6 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] stock_picking_move_description #150

wants to merge 6 commits into from

Conversation

IriaAlonso
Copy link
Contributor

dalonsod
dalonsod approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested LGTM.

Anyway, I've noticed that v15 implementation has no translations, so we've got this pending to he translated, in report:

imagen

and picking form responsive view:

imagen

Could you add these translations, adding yourself as contributor?

dalonsod
dalonsod reviewed Oct 12, 2024
View reviewed changes
stock_picking_move_description/static/description/index.html Outdated
@@ -0,0 +1,420 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And remove this line as usual in v17.

@IriaAlonso IriaAlonso force-pushed the 17.0-mig-stock_picking_move_description branch from 5d21f66 to 9ea79ab Compare October 14, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IriaAlonso @dalonsod @LucPinheiro @adriresu