Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming for delete and deleteTask indexes. #8

Open
soloplxya opened this issue Apr 16, 2022 · 1 comment
Open

Improve naming for delete and deleteTask indexes. #8

soloplxya opened this issue Apr 16, 2022 · 1 comment

Comments

@soloplxya
Copy link
Owner

soloplxya commented Apr 16, 2022

For the delete and deleteTask commands, it seems like they both make use of an id (STUDENT_ID ) and taskid (idx) respectively to identify the items to delete.

image.png

image.png

I think it might be clearer to rename idx as TASK_ID as it is clearer to the readers that it is distinct from its counterpart, STUDENT_ID.

@nus-pe-script
Copy link

nus-pe-script commented Apr 19, 2022

Team's Response

We believe that this suggestion is considered not in scope as optimising this explanation is significantly less important than implementing our other features.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: image.png
I disagree with the evaluation above as it does not fulfill the criteria necessary to be classified as NotInScope as shown in the screenshot above.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants