Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate email addresses should not be allowed. #3

Open
soloplxya opened this issue Apr 16, 2022 · 1 comment
Open

Duplicate email addresses should not be allowed. #3

soloplxya opened this issue Apr 16, 2022 · 1 comment

Comments

@soloplxya
Copy link
Owner

soloplxya commented Apr 16, 2022

Understand from the UG that students are only considered equal if they have the same student ID. However, from a functional perspective, all students should have their own email addresses so that the TA is able to send information to them directly. It might be better to account for an email address in the equality check as well.

Command provided:

image.png

@soc-se-bot
Copy link

soc-se-bot commented Apr 19, 2022

Team's Response

Duplicate of #1162

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add Commnad Doesnt check Unique Telegram Handle / Email address / Phone number

Even though the add command accounted for unique matric number, it did not account for unique telegram handle or unique email address or unique phone number.

NoTeleUnique.png


[original: nus-cs2103-AY2122S2/pe-interim#1006] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We have already specified in the UG, that only student ID is being checked for duplicates. Hence, the other fields do not have to be unique in TAPA. Since this is a suggestion, we believe that implementing our other features is more important than working on duplicate detection for fields that are not student ID for now, especially because the email address is not being used now in our existing features.

image.png

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: I still think that this poses to be a huge problem since the system can contain students with the same student ID but with different email addresses. In this case, how can the TA differentiate and recognize which email address they should send the information to.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants