Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eager_load_paths instead of autoload_paths #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,6 @@ To run [Rubocop](https://github.com/bbatsov/rubocop) static code analysis run
bundle exec rubocop
```

When testing your application's integration with this extension you may use its factories.
Simply add this require statement to your spec_helper:

```ruby
require 'solidus_graphql_api/factories'
```

## Running the sandbox

To run this extension in a sandboxed Solidus application, you can run `bin/sandbox`. The path for
Expand Down
2 changes: 1 addition & 1 deletion lib/solidus_graphql_api/engine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Engine < Rails::Engine
g.test_framework :rspec
end

config.autoload_paths << File.expand_path('..', __dir__)
config.eager_load_paths << File.expand_path('..', __dir__)

initializer "solidus_graphql_api.setup_batch_loader_middleware" do |app|
app.middleware.use BatchLoader::Middleware
Expand Down
9 changes: 0 additions & 9 deletions lib/solidus_graphql_api/testing_support/factories.rb

This file was deleted.

3 changes: 0 additions & 3 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
# in spec/support/ and its subdirectories.
Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }

# Requires factories defined in lib/solidus_graphql_api/testing_support/factories.rb
SolidusDevSupport::TestingSupport::Factories.load_for(SolidusGraphqlApi::Engine)

RSpec.configure do |config|
config.add_setting :default_freeze_date, default: "21/12/2012 12:00:00"
config.add_setting :graphql_queries_dir, default: "spec/support/graphql/queries"
Expand Down