Improve add line item to order #4618
DanielePalombo
started this conversation in
New Features or Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The
add
method in Spree::OrderContents accepts three parameters but it's called without the third in https://github.com/solidusio/solidus/blob/master/frontend/app/controllers/spree/orders_controller.rb#L55 .I think we can pass this as method.
In this way who wants to change the
add
feature doesn't need to override thepopulate
action, but can change logic insideSpree::OrderContents
after modify that method.ex:
The same logic can be applied on
https://github.com/solidusio/solidus/blob/master/api/app/controllers/spree/api/line_items_controller.rb#L15
Beta Was this translation helpful? Give feedback.
All reactions