Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace icon with solidus_icon #32

Open
DanielePalombo opened this issue Jun 23, 2023 · 3 comments
Open

Replace icon with solidus_icon #32

DanielePalombo opened this issue Jun 23, 2023 · 3 comments

Comments

@DanielePalombo
Copy link
Collaborator

DanielePalombo commented Jun 23, 2023 •
edited by MassimilianoLattanzio
Loading

In solidus 2.3 iconhelper has been deprecated to solidus_icon

Ref solidusio/solidus@62a37cc

PR: #17

solidus minimum version: 2.3
@DanielePalombo
Copy link
Collaborator Author

icon is too much generic to deprecate. We agree that we can remove it for now and re-evaluate if it is worth it to reintroduce it, when we'll have a real project to migrate.

@DanielePalombo
Copy link
Collaborator Author

Moved to ready to be removed. Then we can move it to backlog

@DanielePalombo
Copy link
Collaborator Author

This COP could be related to #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielePalombo @MassimilianoLattanzio