Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tax_category= is deprecated and will be removed from Solidus 3.0 (use tax_categories= instead) #25

Open
DanielePalombo opened this issue Jun 23, 2023 · 5 comments
Open

tax_category= is deprecated and will be removed from Solidus 3.0 (use tax_categories= instead) #25

DanielePalombo opened this issue Jun 23, 2023 · 5 comments

Comments

@DanielePalombo
Copy link
Collaborator

No description provided.

@DanielePalombo
Copy link
Collaborator Author

From @MassimilianoLattanzio :

this cop is mark this as an offense but is wrong. I'm not using the TaxRate model but the ShippingMethod one. So here too maybe is better to remove it? cc @danielepalombo

@DanielePalombo
Copy link
Collaborator Author

It is not possible to detect the Class of the variable.

@DanielePalombo DanielePalombo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@DanielePalombo
Copy link
Collaborator Author

It is not possible to detect the Class of the variable.

@DanielePalombo DanielePalombo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@DanielePalombo DanielePalombo mentioned this issue Aug 7, 2023
Open
@piyushswain piyushswain reopened this Aug 11, 2023
@piyushswain
Copy link
Contributor

We can make this cop work with a warning offense instead of a standard offense.

Hence, this has been repoened.

@piyushswain
Copy link
Contributor

Here is the solidus change reference
solidusio/solidus#1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielePalombo @piyushswain