Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button_link_to -> link_to #23

Open
DanielePalombo opened this issue Jun 23, 2023 · 1 comment
Open

button_link_to -> link_to #23

DanielePalombo opened this issue Jun 23, 2023 · 1 comment

Comments

@DanielePalombo
Copy link
Collaborator

DanielePalombo commented Jun 23, 2023

After upgrading to Solidus 2.6, you may encounter deprecation warnings. One of these could be about the button_link_to deprecated in favor of button_to or link_to (ref). To update all occurrences, you can use this simple regex:

Search for <%= button_link_to (.+) %>.

Replace with <%= link_to $1, class: 'btn btn-primary' %> or <%= button_to $1, class: 'btn btn-primary' %> depending on which one you need.

Minimum solidus version: from the beginning

Depending on #37

@DanielePalombo
Copy link
Collaborator Author

From @piyushswain :

erb-lint seems like a different project all together to rubocop 

Although it does have the same working, writing the cops is quite different from rubocop and it would take some time to understand and get it working alongside rubocop-solidus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant