Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] Audit what we're about to release as web3.js Release Candidate for React Native #2402

Open
steveluscher opened this issue Apr 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Apr 1, 2024

We have no React Native test harness, so we don't know if the new library actually works on React Native. Maybe it does, or maybe it's still missing some polyfills.

  • Audit the library's compatibility with React Native (specifically RN >=0.7.0 with the Hermes engine)
  • Wherever there are problems, either
    • Write our code differently to be naturally compatible, or
    • Create a fork of our code that is compatible (example: @solana/text-encoding-impl), or
    • Create a new package (eg. @solana/react-native-polyfill or something) that can be bare-imported to make things work
@steveluscher steveluscher added the enhancement New feature or request label Apr 1, 2024
@steveluscher
Copy link
Collaborator Author

Are you still doing React Native stuff, @beeman?

@beeman
Copy link
Contributor

beeman commented Apr 2, 2024

Are you still doing React Native stuff, @beeman?

At the moment I'm not working on any React Native apps, but I'm happy to dive into it when I have some more free time, like right after HH Dubai.

@steveluscher steveluscher changed the title [experimental] Audit what we're about to release as Technology Preview 3 for React Native [experimental] Audit what we're about to release as Technology Preview 4 for React Native May 10, 2024
@steveluscher
Copy link
Collaborator Author

I tried the new web3.js with a plain Expo app yesterday. With only the introduction of a SubtleCrypto polyfill (I used https://github.com/margelo/react-native-quick-crypto) I was able to generate keypairs and make RPC calls.

There's one ergonomic fix that needs to be made (#2898) and I think we can close this.

@steveluscher steveluscher changed the title [experimental] Audit what we're about to release as Technology Preview 4 for React Native [experimental] Audit what we're about to release as web3.js Release Candidate for React Native Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants