Refactor - Move memory instruction classes #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Oct 4, 2024
src/assembler.rs
Outdated
| "ldx", | ||
| LoadReg, | ||
| ebpf::BPF_MEM | ebpf::BPF_LDX, | ||
| ebpf::BPF_ALU | ebpf::BPF_X, |
There was a problem hiding this comment.
Perhaps we should give BPF_ALU another name, as it is going to be associated with memory operations.
Lichtso
force-pushed
the
refactor/move_memory_instruction_classes
branch
from
98769f8 to
ee154e5
Compare
Renames BPF_ALU64 => BPF_ALU64_STORE.
Lichtso
force-pushed
the
refactor/move_memory_instruction_classes
branch
from
41194f6 to
f1c6741
Compare
LucasSte
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SIMD-0173