Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Config::enabled_sbpf_versions #582

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 25, 2024

Turns the two explicit flags into a range to describe the enabled SBPFVersions in the Config in anticipation of there being a lot more SBPFVersions.

Config::enabled_sbpf_versions is a range and not a set because in some places we need to know the highest enabled SBPFVersion. Also, because features are enabled for ranges of versions themselves, it makes little sense to leave out versions in the middle of a range, so sets are needlessly verbose.

@Lichtso Lichtso force-pushed the refactor/sbpf_version_config branch from e663f6b to c409704 Compare July 25, 2024 16:52
@Lichtso Lichtso force-pushed the refactor/sbpf_version_config branch from c409704 to ff194ed Compare July 25, 2024 17:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (a996494) to head (ff194ed).
Report is 3 commits behind head on main.

Files Patch % Lines
src/elf.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   89.92%   90.01%   +0.09%     
==========================================
  Files          22       22              
  Lines        9735     9673      -62     
==========================================
- Hits         8754     8707      -47     
+ Misses        981      966      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lichtso Lichtso merged commit c72113b into main Jul 26, 2024
12 checks passed
@Lichtso Lichtso deleted the refactor/sbpf_version_config branch July 26, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants