Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrencySearch should not have LastModified as search parameter #260

Open
bpaolo71 opened this issue Nov 23, 2022 · 2 comments
Open

CurrencySearch should not have LastModified as search parameter #260

bpaolo71 opened this issue Nov 23, 2022 · 2 comments

Comments

@bpaolo71
Copy link
Contributor

This work: https://api.fortnox.se/3/currencies?limit=500&page=1
but not this: https://api.fortnox.se/3/currencies?lastmodified=2022-11-23&limit=500&page=1
It returns "Ogiltig parameter i anropet."

Should api allow to do something that it is not allowed ?

@richardrandak
Copy link
Collaborator

Ideally, the SDK should not allow it.. unfortunately, the API documentation does not says what parameters are allowed for which endpoint. In the old documentation, there were several parameters defined as "global", so I have put them to a base search class to be available for all connectors.
To fix this, we would have to discard the base search and put them to each of the resource specific search and then remove the parameters which cause the errors.. or in some cases, not cause errors but not having effect. It already causing pain in testing.

@bpaolo71
Copy link
Contributor Author

bpaolo71 commented Dec 2, 2022

I understand your point of view. I will think about it and come back eventually with suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants