Skip to content
This repository has been archived by the owner on Apr 4, 2020. It is now read-only.

Feature/setup eslint prettier #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jenessawhite
Copy link
Contributor

@jenessawhite jenessawhite commented Nov 18, 2019

This is the first step PR for getting us a standard repo to clone when starting new React projects.
It's bootstrapped with CRA and I've added .eslintrrc.json, .prettierrc.json, and a .nvmrc (if you use a Node version manager that needs a .node-version let me know we can add that) file to keep node versions in check.

This initial PR is just the basic setup, I haven't yet added our anything about how we'll handle styling or testing (because we definitely write JS tests!)

This isn't meant to be a Jenessa is picking what/how we do things, so please give any feedback so that we can discuss what changes we might need to make to make this better for any and everybody that might have to spin up/contribute to our React projects. Also this is my first time doing something like this so if I've missed something we'd need in order to make this work as a "clone & go thing" let me know.

@rybridge
Copy link
Member

Just a question and not really a comment. As Create React App updates...what will we need to do to update this? Is there a way to automagically have it update when CRA does? If there is something we need to do we should probably put it in the readme

@jenessawhite
Copy link
Contributor Author

Just a question and not really a comment. As Create React App updates...what will we need to do to update this? Is there a way to automagically have it update when CRA does? If there is something we need to do we should probably put it in the readme

Good question. I will definitely add stuff to the README for this, CRA does have pretty easy upgrades. We just need to follow the instructions for updating react-scripts.

@rybridge
Copy link
Member

Just a question and not really a comment. As Create React App updates...what will we need to do to update this? Is there a way to automagically have it update when CRA does? If there is something we need to do we should probably put it in the readme

Good question. I will definitely add stuff to the README for this, CRA does have pretty easy upgrades. We just need to follow the instructions for updating react-scripts.

Maybe dependabot can help with it? 🤔

@jenessawhite
Copy link
Contributor Author

@rybridge yeah we'll probably want something to bark at us about keeping this thing up to date.

Copy link

@evanheisler evanheisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, thanks for putting this together @jenessawhite. What do you think about using this repo's issue tracker to manage features and development? Or maybe a todo list in the readme? Things that come to mind are: how we want to do styles, testing, storybook, etc.

As far as integrating this into our projects, we could also publish it as a package like sfg-react-app. That way if we make improvements to this project beyond what CRA releases (for example, changes to linting or using styled components), we can update downstream apps to use them.

@jenessawhite
Copy link
Contributor Author

@evanheisler not at all opposed to that. Maybe we can use the GitHub Projects feature? That way we know where everything is progress wise? Instead of making a new Asana project for it.

Also think that publishing this as a package is an intriguing idea. I think we should strongly consider that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants