Android app crash when navigate back if i use FlashList: Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread! #2530

duongnguyen17 · 2024-11-21T07:52:52Z

Description

My Android app crash when i navigate back from a screen use flash list.
Android studio log error:
Unhandled SoftException
com.facebook.react.bridge.AssertionException: Expected to run on UI thread!
at com.facebook.react.bridge.SoftAssertions.assertCondition(SoftAssertions.kt:37)
at com.facebook.react.bridge.UiThreadUtil.assertOnUiThread(UiThreadUtil.java:46)
at com.facebook.react.views.view.ReactViewGroup.handleAddView(ReactViewGroup.java:570)
at com.facebook.react.views.view.ReactViewGroup.addView(ReactViewGroup.java:607)
at android.view.ViewGroup.addView(ViewGroup.java:5025)
at android.view.ViewGroup.addView(ViewGroup.java:4997)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:412)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startTransitionRecursive(Screen.kt:415)
at com.swmansion.rnscreens.Screen.startRemovalTransition(Screen.kt:380)
at com.swmansion.rnscreens.NativeProxy.notifyScreenRemoved(NativeProxy.kt:48)
at com.facebook.jni.NativeRunnable.run(Native Method)
at android.os.Handler.handleCallback(Handler.java:959)
at android.os.Handler.dispatchMessage(Handler.java:100)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl.lambda$startNewBackgroundThread$2(MessageQueueThreadImpl.java:217)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
at java.lang.Thread.run(Thread.java:1012)

flashlist.webm

Steps to reproduce

Press "Go to Details" button
At Detail screen, navigate back

Snack or a link to a repository

https://github.com/duongnguyen17/pager-vew-demo

Screens version

4.2.0

React Native version

0.76.2

Platforms

Android

JavaScript runtime

Hermes

Workflow

None

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

Android emulator

Device model

No response

Acknowledgements

Yes

kkafar · 2024-11-21T10:10:24Z

Is that a crash or only soft exception is logged?

shankarRxo · 2024-11-21T12:29:09Z

Facing same issue
Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread!

duongnguyen17 · 2024-11-21T12:38:10Z

Is that a crash or only soft exception is logged?
That is a crash

kkafar · 2024-11-21T13:47:32Z

Okay, I've opened the fix in #2532 - if anyone would confirm that it fixes the issue I would be grateful

kkafar · 2024-11-21T13:53:24Z

Once I get confirmation I'll be able to release this

shankarRxo · 2024-11-21T14:40:50Z

Okay, I've opened the fix in #2532 - if anyone would confirm that it fixes the issue I would be grateful

Facing another issue

kkafar · 2024-11-21T14:43:04Z

@shankarRxo namely? :D

DrZoidberg09 · 2024-11-21T15:00:42Z

Almost the same happens on iOS. It does not completely crash, but the FlashList screen is distorted and you cannot press anything anymore.

See here:

callstack/react-native-pager-view#917

Not sure if it comes from pager view, screens or both.

akylbek-hostaways · 2024-11-21T15:07:33Z

@kkafar I also have similar issue, but I'm using FlatList.
Stack trace from sentry:

android.widget.AdapterView in addView at line 489
com.swmansion.rnscreens.Screen in l at line 87
com.swmansion.rnscreens.Screen in l at line 95
11
com.swmansion.rnscreens.Screen in k at line 8
com.swmansion.rnscreens.ScreenStackViewManager in prepareOutTransition at line 3
com.swmansion.rnscreens.ScreenStackViewManager in removeViewAt at line 4
com.swmansion.rnscreens.ScreenStackViewManager in removeViewAt at line 2
com.facebook.react.uimanager.NativeViewHierarchyManager in manageChildren at line 149
com.swmansion.reanimated.layoutReanimation.ReanimatedNativeHierarchyManager in manageChildren at line 8
com.facebook.react.uimanager.UIViewOperationQueue$ManageChildrenOperation in execute at line 15
com.facebook.react.uimanager.UIViewOperationQueue$1 in run at line 145
com.facebook.react.uimanager.UIViewOperationQueue in flushPendingBatches at line 54
com.facebook.react.uimanager.UIViewOperationQueue in w at line 1
com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in doFrameGuarded at line 32
com.facebook.react.uimanager.GuardedFrameCallback in doFrame at line 1
com.facebook.react.modules.core.ReactChoreographer$1 in doFrame at line 47
android.view.Choreographer$CallbackRecord in run at line 1404
android.view.Choreographer$CallbackRecord in run at line 1415
android.view.Choreographer in doCallbacks at line 1015
android.view.Choreographer in doFrame at line 941
android.view.Choreographer$FrameDisplayEventReceiver in run at line 1389
android.os.Handler in handleCallback at line 959
android.os.Handler in dispatchMessage at line 100
android.os.Looper in loopOnce at line 232
android.os.Looper in loop at line 317
android.app.ActivityThread in main at line 8592
java.lang.reflect.Method in invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller in run at line 580
com.android.internal.os.ZygoteInit in main at line 878

"react-native-screens": "^4.2.0", "react-native": "^0.75.4", newArchEnabled=false

duongnguyen17 · 2024-11-21T15:18:36Z

Okay, I've opened the fix in #2532 - if anyone would confirm that it fixes the issue I would be grateful

The issue has been fixed but i got an other issue make my android app crash:

FATAL EXCEPTION: main
Process: com.awesomeproject, PID: 10025
java.lang.IllegalStateException: CellRendererComponent outer view should always be CellContainer. Learn more here: https://shopify.github.io/flash-list/docs/usage#cellrenderercomponent.
at com.shopify.reactnative.flash_list.AutoLayoutView.fixLayout(AutoLayoutView.kt:66)
at com.shopify.reactnative.flash_list.AutoLayoutView.dispatchDraw(AutoLayoutView.kt:32)
at android.view.View.updateDisplayListIfDirty(View.java:23683)
at android.view.View.draw(View.java:24573)
at android.view.ViewGroup.drawChild(ViewGroup.java:4537)
at com.facebook.react.views.view.ReactViewGroup.drawChild(ReactViewGroup.java:1029)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4298)
at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:980)
at android.view.View.updateDisplayListIfDirty(View.java:23683)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.View.draw(View.java:24573)
at android.view.ViewGroup.drawChild(ViewGroup.java:4537)
at com.facebook.react.views.view.ReactViewGroup.drawChild(ReactViewGroup.java:1029)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4298)
at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:980)
at android.view.View.updateDisplayListIfDirty(View.java:23683)
at android.view.View.draw(View.java:24573)
at android.view.ViewGroup.drawChild(ViewGroup.java:4537)
at com.facebook.react.views.view.ReactViewGroup.drawChild(ReactViewGroup.java:1029)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4298)
at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:980)
at android.view.View.draw(View.java:24845)
at com.facebook.react.views.view.ReactViewGroup.draw(ReactViewGroup.java:970)
at android.view.View.updateDisplayListIfDirty(View.java:23692)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4494)
at android.view.View.updateDisplayListIfDirty(View.java:23646)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4521)

Should I report this bug to FlashList?

akylbek-hostaways · 2024-11-21T15:21:23Z

@kkafar I also have similar issue, but I'm using FlatList. Stack trace from sentry:

android.widget.AdapterView in addView at line 489
com.swmansion.rnscreens.Screen in l at line 87
com.swmansion.rnscreens.Screen in l at line 95
11
com.swmansion.rnscreens.Screen in k at line 8
com.swmansion.rnscreens.ScreenStackViewManager in prepareOutTransition at line 3
com.swmansion.rnscreens.ScreenStackViewManager in removeViewAt at line 4
com.swmansion.rnscreens.ScreenStackViewManager in removeViewAt at line 2
com.facebook.react.uimanager.NativeViewHierarchyManager in manageChildren at line 149
com.swmansion.reanimated.layoutReanimation.ReanimatedNativeHierarchyManager in manageChildren at line 8
com.facebook.react.uimanager.UIViewOperationQueue$ManageChildrenOperation in execute at line 15
com.facebook.react.uimanager.UIViewOperationQueue$1 in run at line 145
com.facebook.react.uimanager.UIViewOperationQueue in flushPendingBatches at line 54
com.facebook.react.uimanager.UIViewOperationQueue in w at line 1
com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in doFrameGuarded at line 32
com.facebook.react.uimanager.GuardedFrameCallback in doFrame at line 1
com.facebook.react.modules.core.ReactChoreographer$1 in doFrame at line 47
android.view.Choreographer$CallbackRecord in run at line 1404
android.view.Choreographer$CallbackRecord in run at line 1415
android.view.Choreographer in doCallbacks at line 1015
android.view.Choreographer in doFrame at line 941
android.view.Choreographer$FrameDisplayEventReceiver in run at line 1389
android.os.Handler in handleCallback at line 959
android.os.Handler in dispatchMessage at line 100
android.os.Looper in loopOnce at line 232
android.os.Looper in loop at line 317
android.app.ActivityThread in main at line 8592
java.lang.reflect.Method in invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller in run at line 580
com.android.internal.os.ZygoteInit in main at line 878

"react-native-screens": "^4.2.0", "react-native": "^0.75.4", newArchEnabled=false

Update: I tried to using FlashList, and I don't have this issue with your fix

kkafar · 2024-11-21T15:30:31Z

@duongnguyen17 This might be still related to react-native-screens, namely it might be caused by the workaround. But I won't be able to fix this here, we need the changes to land in react-native core.

The best thing I can suggest for you right now is to build react native from source and apply this patch: facebook/react-native#47634
and comment out this code in react-native-screens:

react-native-screens/android/src/main/java/com/swmansion/rnscreens/Screen.kt

Lines 413 to 429 in 6aaf56b

    
           if (child is ReactClippingViewGroup && 
        
               child.removeClippedSubviews && 
        
               child !is ReactScrollView && 
        
               child !is ReactHorizontalScrollView 
        
           ) { 
        
               // We need to workaround the issue until our changes land in core. 
        
               // Some views do not accept any children or have set amount and they throw 
        
               // when we want to brute-forcefully manipulate that. 
        
               // Is this ugly? Very. Do we have better option before changes land in core? 
        
               // I'm not aware of any. 
        
               try { 
        
                   for (j in 0 until child.childCount) { 
        
                       child.addView(View(context)) 
        
                   } 
        
               } catch (_: Exception) { 
        
               } 
        
           }

:/

akylbek-hostaways · 2024-11-21T15:37:09Z

@kkafar Could my problem with FlatList be related to react-native bug?

duongnguyen17 · 2024-11-21T15:53:02Z

@duongnguyen17 This might be still related to react-native-screens, namely it might be caused by the workaround. But I won't be able to fix this here, we need the changes to land in react-native core.

The best thing I can suggest for you right now is to build react native from source and apply this patch: facebook/react-native#47634 and comment out this code in react-native-screens:

react-native-screens/android/src/main/java/com/swmansion/rnscreens/Screen.kt

Lines 413 to 429 in 6aaf56b

if (child is ReactClippingViewGroup &&

child.removeClippedSubviews &&

child !is ReactScrollView &&

child !is ReactHorizontalScrollView

) {

// We need to workaround the issue until our changes land in core.

// Some views do not accept any children or have set amount and they throw

// when we want to brute-forcefully manipulate that.

// Is this ugly? Very. Do we have better option before changes land in core?

// I'm not aware of any.

try {

for (j in 0 until child.childCount) {

child.addView(View(context))

}

} catch (_: Exception) {

}

}

:/

@kkafar Thank you very much for your help 😁
it work!

kkafar · 2024-11-21T15:54:40Z

@akylbek-hostaways I believe this is the same case. Your code crashes because of our workaround in react-native-screens. We have to add this workaround, because there is other inherent issue in react-native - it does not handle cases where some views might be a part of Android Transition. We're working on it currently, but it might take even few weeks.

The best way to go @akylbek-hostaways right now is with my suggestion above ([link])(#2530 (comment))

kkafar · 2024-11-21T15:55:15Z

@duongnguyen17 glad to hear that. We'll try to sort these things up, so that patches are not required to make things work

duongnguyen17 · 2024-11-21T15:59:59Z

@kkafar but if i comment the code you mentioned, i can't fix the issue with the react-native-pager-view
so i think i will wait for the next version. hihi 😁

duongnguyen17 · 2024-11-21T16:01:20Z

@kkafar you are my hope 😇

shankarRxo · 2024-11-22T06:45:26Z

@shankarRxo namely? :D

java.lang.IllegalStateException: CellRendererComponent outer view should always be CellContainer. Learn more here: https://shopify.github.io/flash-list/docs/usage#cellrenderercomponent.

related to flashList

github-actions bot added Repro provided A reproduction with a snack or repo is provided Platform: Android This issue is specific to Android labels Nov 21, 2024

kkafar linked a pull request Nov 21, 2024 that will close this issue

fix(Android): move calls to start transition to UI thread to prevent possible crash in prod #2532

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android app crash when navigate back if i use FlashList: Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread! #2530

Android app crash when navigate back if i use FlashList: Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread! #2530

duongnguyen17 commented Nov 21, 2024

kkafar commented Nov 21, 2024

shankarRxo commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024

kkafar commented Nov 21, 2024

kkafar commented Nov 21, 2024

shankarRxo commented Nov 21, 2024

kkafar commented Nov 21, 2024

DrZoidberg09 commented Nov 21, 2024

akylbek-hostaways commented Nov 21, 2024 •

edited

Loading

duongnguyen17 commented Nov 21, 2024 •

edited

Loading

akylbek-hostaways commented Nov 21, 2024

kkafar commented Nov 21, 2024 •

edited

Loading

akylbek-hostaways commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024

kkafar commented Nov 21, 2024

kkafar commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024 •

edited

Loading

duongnguyen17 commented Nov 21, 2024

shankarRxo commented Nov 22, 2024

Android app crash when navigate back if i use FlashList: Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread! #2530

Android app crash when navigate back if i use FlashList: Unhandled SoftException com.facebook.react.bridge.AssertionException: Expected to run on UI thread! #2530

Comments

duongnguyen17 commented Nov 21, 2024

Description

Steps to reproduce

Snack or a link to a repository

Screens version

React Native version

Platforms

JavaScript runtime

Workflow

Architecture

Build type

Device

Device model

Acknowledgements

kkafar commented Nov 21, 2024

shankarRxo commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024

kkafar commented Nov 21, 2024

kkafar commented Nov 21, 2024

shankarRxo commented Nov 21, 2024

kkafar commented Nov 21, 2024

DrZoidberg09 commented Nov 21, 2024

akylbek-hostaways commented Nov 21, 2024 • edited Loading

duongnguyen17 commented Nov 21, 2024 • edited Loading

akylbek-hostaways commented Nov 21, 2024

kkafar commented Nov 21, 2024 • edited Loading

akylbek-hostaways commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024

kkafar commented Nov 21, 2024

kkafar commented Nov 21, 2024

duongnguyen17 commented Nov 21, 2024 • edited Loading

duongnguyen17 commented Nov 21, 2024

shankarRxo commented Nov 22, 2024

akylbek-hostaways commented Nov 21, 2024 •

edited

Loading

duongnguyen17 commented Nov 21, 2024 •

edited

Loading

kkafar commented Nov 21, 2024 •

edited

Loading

duongnguyen17 commented Nov 21, 2024 •

edited

Loading