Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Reanimated events are not sent on the Fabric "bridgefull" IOS build #2516

Open
k4rpen opened this issue Nov 19, 2024 · 0 comments
Open
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@k4rpen
Copy link

k4rpen commented Nov 19, 2024

Description

In our project, navigation is based on Reanimated events (such as onWillAppear, onWillDisappear, onTransitionProgress), after enabling Fabric + bridgefull, we saw that events on iOS stopped being sent

Sandbox with problem reproduction
https://github.com/k4rpen/react-native-screens-issue

For example, I added receiving the onWillAppear event in the ReanimatedNativeStackScreen

const onWillAppearReanimated = useEvent(
    event => {
      'worklet';
      console.log('!!!onWillAppearReanimated', event);
    },
    [Platform.OS === 'android' ? 'onWillAppear'
      : ENABLE_FABRIC 
      ? 'onWillAppear' 
      : 'topWillAppear'
    ],
  );
  
...
  
onWillAppear={() => console.log('!!!onWillAppear JS')}
onWillAppearReanimated={onWillAppearReanimated}

These events work on Android:

old-arch
old-arch-android

Fabric + bridgeless (it is also interesting that events are doubled)

bridgeless-android

Fabric + bridgefull (it is also interesting that events are doubled)

bridgefull-android

On iOS, they don't work only on bridgefull:

old-arch

old-arch-ios

bridgeless

bridgeless-ios

bridgefull
bridgefull-ios

Steps to reproduce

  1. Enable Fabric
  2. Disable bridgeless mode

Snack or a link to a repository

https://github.com/k4rpen/react-native-screens-issue

Screens version

3.32.0 / 3.34.0

React Native version

0.74.5

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug/Release

Device

iOS simulator

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Repro provided A reproduction with a snack or repo is provided Platform: iOS This issue is specific to iOS labels Nov 19, 2024
@k4rpen k4rpen changed the title [IOS] Reanimated events are not sent on the Fabric "bridgefull" IOS build [Fabric] Reanimated events are not sent on the Fabric "bridgefull" IOS build Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

1 participant