Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI.Component] Add virtualization for attachment performer #4638

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Apr 9, 2024

Add virtualization layer to attachment performers.

There exists two of them, either using lagrangian based constraints or springs. A common method start_partial already existed that was supposed to add required components and parametrize them to either add bilateral constraint or a spring, but this common mechanism was not link with any virtual inheritance.

I need to handle both performers blindly using this method (start_partial) so I added a virtualization layer that makes more sens than what currently exists. I use it in this PR -> (Sofa.IGTLink PR).

I've also took advantage of this refactoring to rename some attributes that where not following the naming policy, because why not.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request labels Apr 9, 2024
@bakpaul
Copy link
Contributor Author

bakpaul commented Apr 9, 2024

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

Looks good to me but a bit hard to review due to the mix of changes. It would have been easier with two separate PRs

Copy link
Contributor

@hugtalbot hugtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 17, 2024
@fredroy fredroy force-pushed the add_virtualization_for_attachment_performer branch from b2e5677 to f164372 Compare April 18, 2024 00:39
@fredroy fredroy merged commit 74acc2d into sofa-framework:master Apr 18, 2024
9 of 11 checks passed
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants