-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI.Component] Add virtualization for attachment performer #4638
Merged
fredroy
merged 10 commits into
sofa-framework:master
from
bakpaul:add_virtualization_for_attachment_performer
Apr 18, 2024
Merged
[GUI.Component] Add virtualization for attachment performer #4638
fredroy
merged 10 commits into
sofa-framework:master
from
bakpaul:add_virtualization_for_attachment_performer
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakpaul
added
pr: breaking
Change possibly inducing a compilation error
pr: status to review
To notify reviewers to review this pull-request
labels
Apr 9, 2024
[ci-build][with-all-tests] |
Looks good to me but a bit hard to review due to the mix of changes. It would have been easier with two separate PRs |
hugtalbot
reviewed
Apr 10, 2024
Sofa/GUI/Component/src/sofa/gui/component/performer/BaseAttachBodyPerformer.inl
Outdated
Show resolved
Hide resolved
hugtalbot
reviewed
Apr 10, 2024
Sofa/GUI/Component/src/sofa/gui/component/performer/BaseAttachBodyPerformer.inl
Outdated
Show resolved
Hide resolved
hugtalbot
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For readability
hugtalbot
approved these changes
Apr 17, 2024
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Apr 17, 2024
…BodyPerformer.inl Co-authored-by: Hugo <[email protected]>
…BodyPerformer.inl Co-authored-by: Hugo <[email protected]>
fredroy
force-pushed
the
add_virtualization_for_attachment_performer
branch
from
April 18, 2024 00:39
b2e5677
to
f164372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: breaking
Change possibly inducing a compilation error
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add virtualization layer to attachment performers.
There exists two of them, either using lagrangian based constraints or springs. A common method
start_partial
already existed that was supposed to add required components and parametrize them to either add bilateral constraint or a spring, but this common mechanism was not link with any virtual inheritance.I need to handle both performers blindly using this method (
start_partial
) so I added a virtualization layer that makes more sens than what currently exists. I use it in this PR -> (Sofa.IGTLink PR).I've also took advantage of this refactoring to rename some attributes that where not following the naming policy, because why not.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if