Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test visual flags in a unit test #5157

Open
bakpaul opened this issue Dec 11, 2024 · 0 comments
Open

Test visual flags in a unit test #5157

bakpaul opened this issue Dec 11, 2024 · 0 comments
Assignees
@bakpaul
Labels
issue: bug (minor) Bug affecting only some users or with no major impact on the framework
Milestone
v25.06

Comments

@bakpaul
Copy link
Contributor

bakpaul commented Dec 11, 2024 •
edited
Loading

Following this PR #5152 we need to test the state of the visual flags at each step of the drawing (updateViual, drawVisual etc...) in a unit Test.

Idea: Create a custom visual object that will just output the current flags in those steps. Use it then in a unit test where we create a simple scene and then change the flags in between timesteps.
@bakpaul bakpaul added the issue: bug (minor) Bug affecting only some users or with no major impact on the framework label Dec 11, 2024
@bakpaul bakpaul added this to the v25.06 milestone Dec 11, 2024
@bakpaul bakpaul self-assigned this Dec 11, 2024
@hugtalbot hugtalbot mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bakpaul bakpaul

Labels
issue: bug (minor) Bug affecting only some users or with no major impact on the framework
Projects
None yet
Milestone
v25.06
Development

No branches or pull requests
1 participant
@bakpaul