Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlocMatrixWriter.h can be deprecated #4986

Open
alxbilger opened this issue Sep 11, 2024 · 0 comments
Open

BlocMatrixWriter.h can be deprecated #4986

alxbilger opened this issue Sep 11, 2024 · 0 comments

Comments

@alxbilger
Copy link
Contributor

Sofa/framework/Core/src/sofa/core/behavior/BlocMatrixWriter.h can be deprecated. The approach is not widely used (only one force field). If I understood correctly, the strategy was to detect if the matrix is a compressed row sparse matrix using a dynamic_cast, to efficiently insert matrix entries. However, this is no longer needed since compressed row sparse matrices now support efficient block insertion even through the BaseMatrix interface (because of https://github.com/sofa-framework/sofa/pull/2306/files among other PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant