Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: apply SOFA's fix on TopologicalMapping #124

Merged
merged 1 commit into from
May 13, 2024
Merged

Example: apply SOFA's fix on TopologicalMapping #124

merged 1 commit into from
May 13, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 28, 2023

on 3instruments_collision.scn .

Possible since

before: 5000 iterations done in 73.286 s ( 68.2259 FPS)
after: 5000 iterations done in 43.573 s ( 114.75 FPS)

~1.7x faster ✌️

@fredroy fredroy added enhancement New feature or request pr: new feature pr: status to review To notify reviewers to review this pull-request labels Dec 28, 2023
@fredroy fredroy force-pushed the update_3inst_collis branch from 79d3a95 to 97edf91 Compare February 8, 2024 01:18
@fredroy fredroy force-pushed the update_3inst_collis branch from 97edf91 to e43326f Compare March 29, 2024 06:13
@fredroy fredroy force-pushed the update_3inst_collis branch from e43326f to 9f81513 Compare April 23, 2024 00:52
epernod
epernod approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the speedup with same results! ㊗️

Before: 5000 iterations done in 57.9164 s ( 86.3314 FPS)
After: 5000 iterations done in 31.4744 s ( 158.859 FPS).

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2024
@epernod epernod merged commit 4f0f30c into sofa-framework:master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request pr: new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredroy @epernod