Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InterventionalRadiologyController] Clean applyInterventionalRadiologyController #106

Merged
merged 10 commits into from
Dec 7, 2023
Merged

[InterventionalRadiologyController] Clean applyInterventionalRadiologyController #106

merged 10 commits into from
Dec 7, 2023

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 28, 2023 •
edited
Loading

Based on #105, #104 and #120

  • Rewrite totalLengthIsChanging to avoid error message of curvAbs further to tool tip
  • Massive clean and doc in the method applyInterventionalRadiologyController

@epernod epernod added pr: clean pr: status to review To notify reviewers to review this pull-request labels Jul 28, 2023
@epernod epernod marked this pull request as draft July 28, 2023 08:44
@epernod epernod marked this pull request as ready for review November 27, 2023 15:50
@epernod epernod mentioned this pull request Nov 28, 2023
Merged
@epernod
[IRCtrl] Rewrite totalLengthIsChanging
298733d
@epernod
[IRCtrl] Update turn the check of wrong abscisse curv from error to w…
1f1be44 
…arning. It should not happened anymore with the new version of totalLengthChanged and if happening will use last id of buffer ensuring no crash.
@epernod
[IRCtrl] Some constifying and cleanup
462c4d0
@epernod
Fix: add some check on beam/dof sizes
1a861a2
@epernod
Fix: method totalLengthIsChanging: do not delete redondant 0 absciss …
1adb6ab 
…to avoid small behavior bump and make sure the last tool start at the same absciss as previous tool
@epernod
Another fix for method totalLengthIsChanging:
46e2bc9
@epernod
Merge branch 'master' into inf_IRCtrl_clean2
cd65990 
# Conflicts:
#	src/BeamAdapter/component/controller/InterventionalRadiologyController.inl
@epernod epernod mentioned this pull request Nov 30, 2023
Closed
@fredroy fredroy merged commit a243f9c into sofa-framework:master Dec 7, 2023
2 of 4 checks passed
@epernod epernod deleted the inf_IRCtrl_clean2 branch December 11, 2023 11:03
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean pr: fix pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epernod @fredroy