New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modifying document.domain no longer supported #629

Open

phillipse01 opened this issue May 31, 2023 · 1 comment

phillipse01 commented May 31, 2023

Chrome Firefox and Edge have moved to not allow document.domain modification. Example article from chrome:
https://developer.chrome.com/blog/immutable-document-domain/

This is currently used in sockjs-client/lib/utils/iframe.js:

sockjs-client/lib/utils/iframe.js

Lines 153 to 157 in 63b845f

    
           doc.open(); 
        
           doc.write('<html><s' + 'cript>' + 
        
                     'document.domain="' + global.document.domain + '";' + 
        
                     '</s' + 'cript></html>'); 
        
           doc.close();

This will no longer work

auvipy commented Jun 2, 2023

can you send PR, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment