Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoTestIgnoreRuleTest should also check for @ArchIgnore #10

Open
1 of 3 tasks
daniel-shuy opened this issue Dec 17, 2019 · 2 comments
Open
1 of 3 tasks

NoTestIgnoreRuleTest should also check for @ArchIgnore #10

daniel-shuy opened this issue Dec 17, 2019 · 2 comments

Comments

@daniel-shuy
Copy link

Summary

NoTestIgnoreRuleTest should also flag @ArchIgnore annotations without a provided reason

Type of Issue

It is a :

  • bug
  • request
  • question regarding the documentation

Motivation

Currently NoTestIgnoreRuleTest only checks for JUnit 4's @Ignore and JUnit 5's @Disable, but does not check for ArchUnit's @ArchIgnore annotation.
@vincent-fuchs
Copy link
Collaborator

In which dependency is this annotation located ? I am not getting it right now..

@daniel-shuy
Copy link
Author

archunit-junit5-api (https://www.archunit.org/userguide/html/000_Index.html#_ignoring_tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincent-fuchs @daniel-shuy