Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.driftignore: Inline comments being ignored #1688

Open
syphernl opened this issue Sep 4, 2023 · 0 comments
Open

.driftignore: Inline comments being ignored #1688

syphernl opened this issue Sep 4, 2023 · 0 comments
Labels
kind/bug Something isn't working

Comments

@syphernl
Copy link

syphernl commented Sep 4, 2023

Description
Imaging having a .driftignore file with these contents:

aws_iam_role.foo
aws_iam_role.bar
aws_iam_role.baz # created manually as a test

Running driftctl scan on this will still show aws_iam_role.baz as existing without it being created via IaC.

Changing the .driftignore file to this:

aws_iam_role.foo
aws_iam_role.bar

# created manually as a test
aws_iam_role.baz

results in driftctl properly ignoring the aws_iam_role.baz entry.

Environment

  • OS: Ubuntu / Alpine
  • driftctl version: v0.39.0
  • terraform version: v1.5.6
  • terraform providers versions:

How to reproduce
See above

Possible Solution
Allow in-line comments to be placed, anything besides a # should be ignored. To my knowledge there are no entities that contain a #?

Additional context

@syphernl syphernl added the kind/bug Something isn't working label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant