crush: adding new bucket type #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
fixed crush_make_consthash_bucket
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
# Conflicts: # src/crush/builder.c # src/crush/crush.c # src/crush/crush.h # src/crush/mapper.c # src/tools/crushtool.cc
Signed-off-by: Dongmin Lee <[email protected]>
Signed-off-by: Dongmin Lee <[email protected]>
gwuiinKim
changed the title
|
Thanks for your effort. First of all, I'd suggest that the commits you posted should be re-arranged. Each commit should represent what you did on the component/module basis. For instance, add title such as "src/crush: add journal replay", and then add explanation in the body. There are too many meaningless commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding new bucket types to CRUSH algorithm.
Existing bucket types do not work as expected, so improvements are needed.
In this pull request, we developed two new bucket type named "consthash" and "uniform2".
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows