Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native groupBy functions not being used in IsSequence instances #251

Open
BebeSparkelSparkel opened this issue Nov 27, 2024 · 0 comments · May be fixed by #252
Open

Native groupBy functions not being used in IsSequence instances #251

BebeSparkelSparkel opened this issue Nov 27, 2024 · 0 comments · May be fixed by #252

Comments

@BebeSparkelSparkel
Copy link
Collaborator

Multiple cases of --groupBy makeing the instances use the default implementation which uses list which has poor performance. Instances include:

  • V.Vector
  • U.Vector
  • VS.Vector
  • Seq.Seq
@BebeSparkelSparkel BebeSparkelSparkel mentioned this issue Nov 27, 2024
Merged
BebeSparkelSparkel added a commit to BebeSparkelSparkel/mono-traversable that referenced this issue Nov 28, 2024
@BebeSparkelSparkel
Enabled native groupBy for vector
dce5501 
groupBy been available since vector-0.13.0.0
closes snoyberg#251
@BebeSparkelSparkel BebeSparkelSparkel linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabled native groupBy for vector BebeSparkelSparkel/mono-traversable
1 participant
@BebeSparkelSparkel