Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semigroup on GrowingAppend #246

Open
Benjamin-McRae-Tracsis opened this issue Nov 18, 2024 · 3 comments · May be fixed by #248
Open

Semigroup on GrowingAppend #246

Benjamin-McRae-Tracsis opened this issue Nov 18, 2024 · 3 comments · May be fixed by #248

Comments

@Benjamin-McRae-Tracsis
Copy link

It's been about 8 years since Semigroup was added to base, and one full major GHC version since then.

I feel it is time to release a breaking change and require Semigroup on GrowingAppend, allowing classes that use GrowingAppend to use Semigroup without having to add additional classes.
@BebeSparkelSparkel
Copy link
Collaborator

The documentation for both GrowingAppend states

This should have a Semigroup superclass constraint, however, due to Semigroup only recently moving to base, some packages do not provide instances.

The git blame for this is from 2016

a5245687 (Michael Snoyman 2016-06-27 15:07:10 +0300 1452) -- This should have a @Semigroup@ superclass constraint, however, due to
a5245687 (Michael Snoyman 2016-06-27 15:07:10 +0300 1453) -- @Semigroup@ only recently moving to base, some packages do not provide
a5245687 (Michael Snoyman 2016-06-27 15:07:10 +0300 1454) -- instances.
a5245687 (Michael Snoyman 2016-06-27 15:07:10 +0300 1455) class MonoFoldable mono => GrowingAppend mono

Does anyone have any objections?

@jcmartin
Copy link
Contributor

I think this would be a welcome change.

@Benjamin-McRae-Tracsis Benjamin-McRae-Tracsis linked a pull request Nov 19, 2024 that will close this issue
Open
@Benjamin-McRae-Tracsis
Copy link
Author

made the PR for when it's agreed upon.

I think this is a breaking change so we should probably do a new major release; as a result, it's an opportunity to do more breaking changes

@BebeSparkelSparkel BebeSparkelSparkel mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add semigroup to growing append Benjamin-McRae-Tracsis/mono-traversable
3 participants
@jcmartin @BebeSparkelSparkel @Benjamin-McRae-Tracsis