Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pull request reviews before merging #228

Open
BebeSparkelSparkel opened this issue Jul 12, 2024 · 9 comments
Open

Require pull request reviews before merging #228

BebeSparkelSparkel opened this issue Jul 12, 2024 · 9 comments

Comments

@BebeSparkelSparkel
Copy link
Collaborator

@andreasabel @gregwebs @kbillings @maxcan @MaxGabriel

Are any of you still interested and have time to review/approve pull requests?

If so, what do you think about implementing required pull request views before merging?

@andreasabel
Copy link
Collaborator

@BebeSparkelSparkel I am just a one-shot contributor to this package (in Sep 2021), having done some simple maintenance that does not requires to understand the inner workings of this package. So, please do not consider me as reviewer for this package. But thanks for asking!

@BebeSparkelSparkel
Copy link
Collaborator Author

@andreasabel Thanks for letting me know!

@gregwebs
Copy link
Collaborator

@BebeSparkelSparkel are you interested in becoming a maintainer?

@BebeSparkelSparkel
Copy link
Collaborator Author

I use this a lot so yes

@gregwebs
Copy link
Collaborator

@snoyberg can you work out a transition. Do you want to add @BebeSparkelSparkel as a maintainer?

@BebeSparkelSparkel
Copy link
Collaborator Author

BebeSparkelSparkel commented Jul 12, 2024

@gregwebs I already have write permissions. Do I need any others?

@gregwebs
Copy link
Collaborator

write on Github? Then there's the issue of releasing versions to Hackage

@BebeSparkelSparkel
Copy link
Collaborator Author

Good point about hackage.

@snoyberg
Copy link
Owner

@BebeSparkelSparkel if you send me your Hackage username and which packages you'd like to maintain there, happy to add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants