Optionally Pass in the ConnectionContext when creating the TLS Manager

[jfischoff]

For profiling purposes I need to create many (~1000) separate Managers. This is fine for HTTP, but if I need TLS I run into memory and performance issues due to the slow and expensive creation of the ConnectionContext.

I would like to be able to create a single certificate store and share it between Managers.

One way to enable this would be to modify the current mkManagerSettings

mkManagerSettings :: TLSSettings -> Maybe SockSettings -> Maybe ConnectionContext -> ManagerSettings

Alternatively a new function for creation could be added

mkManagerSettingsWithContext :: TLSSettings -> Maybe SockSettings -> Maybe ConnectionContext -> ManagerSettings

[snoyberg]

Check out #227, which has a very similar flavor to this. That PR is blocked on some understanding around laziness of creation, but simply providing a WithContext ability could be done immediately if this is urgent.

[jfischoff]

I looked closer at the code and see the new mkManagerSettingsContext (https://github.com/snoyberg/http-client/pull/227/files#diff-289ca8a43a0c204643df4a048f8d4ddeR44) which is entirely sufficient for my purposes.

I'm not currently blocked by this FWIW, but will either have to fork http-client temporarily or will become blocked in the next few weeks.

[snoyberg]

In that case, I may as well expose mkManagerSettingsContext on master and cut a release. We can deal with the rest of #227 after that.

[snoyberg]

I just pushed a commit to master with this, want to check it out before I release?

[jfischoff]

LGTM
On Thu, Sep 15, 2016 at 11:53 AM Michael Snoyman [email protected]
wrote:

I just pushed a commit to master with this, want to check it out before I
release?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#228 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKSO2mef4dfbSFHM_XUaaoC03P0z7f1ks5qqWnsgaJpZM4J96ij
.

[snoyberg]

Awesome, released. I'll rebase the other branch on top of this.