Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for allow_null_dvce_tstamps var #176

Merged

Conversation

agnessnowplow
Copy link
Contributor

@agnessnowplow agnessnowplow commented Jul 17, 2024

Description

Some of our trackers (e.g specific older versions of the AMP tracker or the Pixel tracker) do not send any value for dvce_created_tstamp and dvce_sent_tstamp. While the snowplow sessionization logic adds a filter to prevent potentially large table scans and reprocessing old sessions that are sent exceptionally late (e.g due to a bot) for such cases this should not matter as there is no retry on those trackers: events are sent right after tracking them or not at all.

This PR allows for setting a variable to coalesce the value with collector_tstamp, which should be available in all trackers.

This should not be a breaking change as it is added as an optional parameter. So far it has been tested locally and in this Unified PR.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

macros/base/base_create_snowplow_events_this_run.sql Outdated Show resolved Hide resolved
@agnessnowplow agnessnowplow merged commit 9b0cc7a into release/snowplow-utils/0.16.8 Jul 22, 2024
5 checks passed
@agnessnowplow agnessnowplow deleted the allow_for_null_dvce_tstamps branch July 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants