Allow for allow_null_dvce_tstamps var #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our trackers (e.g specific older versions of the AMP tracker or the Pixel tracker) do not send any value for
dvce_created_tstamp
anddvce_sent_tstamp
. While the snowplow sessionization logic adds a filter to prevent potentially large table scans and reprocessing old sessions that are sent exceptionally late (e.g due to a bot) for such cases this should not matter as there is no retry on those trackers: events are sent right after tracking them or not at all.This PR allows for setting a variable to coalesce the value with
collector_tstamp
, which should be available in all trackers.This should not be a breaking change as it is added as an optional parameter. So far it has been tested locally and in this Unified PR.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?