Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apply_grants): allow blank grant_config #175

Closed

Conversation

bassrock
Copy link

@bassrock bassrock commented Jul 10, 2024

Description

This PR fixes apply_grants to ensure that grants_config is defined even if the user does not set it.

This aims to solve the following issue:

23:39:56  
23:39:56
23:39:56    Compilation Error in model snowplow_unified_app_errors (models/optional_modules/app_errors/snowplow_unified_app_errors.sql)
  'grant_config' is undefined
  
  > in macro apply_grants (macros/adapters/apply_grants.sql)
  > called by macro materialization_clone_default (macros/materializations/models/clone/clone.sql)
  > called by model snowplow_unified_app_errors (models/optional_modules/app_errors/snowplow_unified_app_errors.sql)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Checklist

  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Jul 10, 2024
@bassrock bassrock marked this pull request as ready for review July 10, 2024 00:32
@bassrock bassrock requested a review from a team as a code owner July 10, 2024 00:32
@ilias1111 ilias1111 changed the base branch from main to release/snowplow-utils/0.16.8 July 25, 2024 16:59
@ilias1111 ilias1111 marked this pull request as draft July 25, 2024 17:24
@ilias1111 ilias1111 marked this pull request as ready for review July 25, 2024 17:24
@ilias1111 ilias1111 mentioned this pull request Jul 25, 2024
19 tasks
@agnessnowplow agnessnowplow force-pushed the release/snowplow-utils/0.16.8 branch 8 times, most recently from 4989f0f to 9e1ee1c Compare July 29, 2024 11:22
@agnessnowplow agnessnowplow deleted the branch snowplow:release/snowplow-utils/0.16.8 July 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants