Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Web: Rename min_tstamp in sessions_userid_manifest_this_run #77

Open
bill-warner opened this issue Apr 20, 2021 · 3 comments
Open

Comments

@bill-warner
Copy link
Contributor

Inconsistent naming of the tstamp between sessions_userid_manifest_staged and sessions_userid_manifest_this_run.

Suggest we change min_tstamp to start_tstamp here to align with other web models.

@colmsnowplow
Copy link
Collaborator

colmsnowplow commented Apr 20, 2021

It's min_tstamp in Redshift too

I'm on board with changing the name to whatever. I think I went with min_tstamp as it represents the first timestamp found for a given domain_userid, rather than the start of a session/page view. In my head, the thought process was that if we want it to be called start_tstamp, it should be first_start_tstamp.

Having said that, it's all entirely academic, so whatever we wanna name it I won't argue - I agree that it should have the same name across all 3 though. :)

@bill-warner
Copy link
Contributor Author

All fair points. I think given a) we use start_tstamp within the users module to denote the first time a user is active and b) the sessions_userid_manifest_staged table, which we insert the data into, uses start_tstamp across all 3 models already it makes most sense to rename to start_tstamp

@colmsnowplow
Copy link
Collaborator

Fair, I'm on board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants